github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-14 06:15:45 +00:00
Code Issues Projects Releases Wiki Activity

Fix a potential bug in TestControllerBurstReplicas: manager.podStore.Store.Add(&pod) actually adds a pointer to a local copy of pod

Browse Source
This commit is contained in:
Lv Lv 2015-05-15 13:41:34 +08:00
parent a91a7bfe77
commit 433a249610
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/controller/replication_controller_test.go
View File

@ -889,9 +889,9 @@ func doTestControllerBurstReplicas(t *testing.T, burstReplicas, numReplicas int)
// This simulates the watch events for all but 1 of the expected pods. // This simulates the watch events for all but 1 of the expected pods.
// None of these should wake the controller because it has expectations==BurstReplicas. // None of these should wake the controller because it has expectations==BurstReplicas.
for _, pod := range pods.Items[:expectedPods-1] { for i := 0; i < expectedPods-1; i++ {
manager.podStore.Store.Add(&pod) manager.podStore.Store.Add(&pods.Items[i])
manager.addPod(&pod) manager.addPod(&pods.Items[i])
} }
podExp, exists, err := manager.expectations.GetExpectations(controllerSpec) podExp, exists, err := manager.expectations.GetExpectations(controllerSpec)
@ -907,9 +907,9 @@ func doTestControllerBurstReplicas(t *testing.T, burstReplicas, numReplicas int)
expectedPods = burstReplicas expectedPods = burstReplicas
} }
validateSyncReplication(t, &fakePodControl, 0, expectedPods) validateSyncReplication(t, &fakePodControl, 0, expectedPods)
for _, pod := range pods.Items[:expectedPods-1] { for i := 0; i < expectedPods-1; i++ {
manager.podStore.Store.Delete(&pod) manager.podStore.Store.Delete(&pods.Items[i])
manager.deletePod(&pod) manager.deletePod(&pods.Items[i])
} }
podExp, exists, err := manager.expectations.GetExpectations(controllerSpec) podExp, exists, err := manager.expectations.GetExpectations(controllerSpec)
if !exists || err != nil { if !exists || err != nil {