From 5639cd97a1f12ffcbaa4917107e500c64ae22e19 Mon Sep 17 00:00:00 2001 From: Stephen Augustus Date: Tue, 2 Feb 2021 15:41:03 -0500 Subject: [PATCH 1/2] OWNERS(CHANGELOG): Move reviewers/approvers to CHANGELOG/ dir Given we're pulling the relnotes team into review, the changes to reviewers will happen a little more frequently, which means we'll have the same issue of needing a top-level approver to do updates that we were trying to avoid by creating the subdirectory in the first place. Signed-off-by: Stephen Augustus --- CHANGELOG/OWNERS | 16 ++++++++++++++-- OWNERS_ALIASES | 16 ---------------- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/CHANGELOG/OWNERS b/CHANGELOG/OWNERS index 032f117b98b..a771f1bf57b 100644 --- a/CHANGELOG/OWNERS +++ b/CHANGELOG/OWNERS @@ -1,9 +1,21 @@ # See the OWNERS docs at https://go.k8s.io/owners approvers: - - changelog-approvers + - wilsonehusin # 1.21 Release Notes Lead + - cpanato # Release Manager + - feiskyer # Release Manager + - hasheddan # Release Manager / SIG Technical Lead + - idealhack # Release Manager + - justaugustus # Release Manager / SIG Chair + - puerco # Release Manager + - saschagrunert # Release Manager / SIG Chair + - xmudrii # Release Manager reviewers: - - changelog-reviewers + - wilsonehusin # 1.21 Release Notes Lead + - ashnehete # 1.21 Release Notes shadow + - melodychn # 1.21 Release Notes shadow + - pmmalinov01 # 1.21 Release Notes shadow + - soniasingla # 1.21 Release Notes shadow labels: - sig/release diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 82ae29f8074..7a79f4c55cc 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -153,22 +153,6 @@ aliases: - puerco # Release Manager - saschagrunert # Release Manager / SIG Chair - xmudrii # Release Manager - changelog-approvers: - - wilsonehusin # 1.21 Release Notes Lead - - cpanato # Release Manager - - feiskyer # Release Manager - - hasheddan # Release Manager / SIG Technical Lead - - idealhack # Release Manager - - justaugustus # Release Manager / SIG Chair - - puerco # Release Manager - - saschagrunert # Release Manager / SIG Chair - - xmudrii # Release Manager - changelog-reviewers: - - wilsonehusin # 1.21 Release Notes Lead - - ashnehete # 1.21 Release Notes shadow - - melodychn # 1.21 Release Notes shadow - - pmmalinov01 # 1.21 Release Notes shadow - - soniasingla # 1.21 Release Notes shadow sig-storage-approvers: - saad-ali From 1a43c6578af7332324df57934813134b480f2ac1 Mon Sep 17 00:00:00 2001 From: Stephen Augustus Date: Tue, 2 Feb 2021 15:45:14 -0500 Subject: [PATCH 2/2] build/OWNERS: Add Dan and Sascha as reviewers Dan and Sascha are senior Release Managers, SIG Release leadership, and have already been giving thoughtful reviews of the content in this directory. Adding them as reviewers to spread the load of SIG Release eyes on content. Signed-off-by: Stephen Augustus --- build/OWNERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build/OWNERS b/build/OWNERS index 0df127a0141..7814c7b92e7 100644 --- a/build/OWNERS +++ b/build/OWNERS @@ -5,8 +5,10 @@ reviewers: - cblecker - dims - fejta - - justaugustus + - hasheddan # Release Manager / SIG Technical Lead + - justaugustus # Release Manager / SIG Chair - lavalamp + - saschagrunert # Release Manager / SIG Chair - spiffxp approvers: - bentheelder