github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 12:43:23 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #112953 from tkashem/fix-typo

Browse Source 
apiserver: fix typo in graceful termination test
This commit is contained in:
Kubernetes Prow Robot 2022-10-17 13:09:30 -07:00 committed by GitHub
commit 44e33fd74b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/apiserver/pkg/server/genericapiserver_graceful_termination_test.go
View File

@ -79,7 +79,7 @@ func (w *wrappedLifecycleSignal) Signal() {
} }
} }
func wrapLifecycleSignalsWithRecorer(t *testing.T, signals *lifecycleSignals, before func(lifecycleSignal)) { func wrapLifecycleSignalsWithRecorder(t *testing.T, signals *lifecycleSignals, before func(lifecycleSignal)) {
// it's important to record the signal being fired on a 'before' callback // it's important to record the signal being fired on a 'before' callback
// to avoid flakes, since on the server the signaling of events are // to avoid flakes, since on the server the signaling of events are
// an asynchronous process. // an asynchronous process.
@ -124,7 +124,7 @@ func newSignalInterceptingTestStep() *signalInterceptingTestStep {
// described in the following diagram // described in the following diagram
// - every vertical line is an independent timeline // - every vertical line is an independent timeline
// - the leftmost vertical line represents the go routine that // - the leftmost vertical line represents the go routine that
// is executing GenericAPIServer.Run methos // is executing GenericAPIServer.Run method
// - (signal name) indicates that the given lifecycle signal has been fired // - (signal name) indicates that the given lifecycle signal has been fired
// //
// stopCh // stopCh
@ -185,7 +185,7 @@ func TestGracefulTerminationWithKeepListeningDuringGracefulTerminationDisabled(t
signals := &s.lifecycleSignals signals := &s.lifecycleSignals
recorder := &signalRecorder{} recorder := &signalRecorder{}
wrapLifecycleSignalsWithRecorer(t, signals, recorder.before) wrapLifecycleSignalsWithRecorder(t, signals, recorder.before)
// before the AfterShutdownDelayDuration signal is fired, we want // before the AfterShutdownDelayDuration signal is fired, we want
// the test to execute a verification step. // the test to execute a verification step.
@ -393,7 +393,7 @@ func TestGracefulTerminationWithKeepListeningDuringGracefulTerminationEnabled(t
signals := &s.lifecycleSignals signals := &s.lifecycleSignals
recorder := &signalRecorder{} recorder := &signalRecorder{}
wrapLifecycleSignalsWithRecorer(t, signals, recorder.before) wrapLifecycleSignalsWithRecorder(t, signals, recorder.before)
// before the AfterShutdownDelayDuration signal is fired, we want // before the AfterShutdownDelayDuration signal is fired, we want
// the test to execute a verification step. // the test to execute a verification step.