From 649523ce911c074bfb0a62fcdb004449c1b00f1f Mon Sep 17 00:00:00 2001 From: Dave Chen Date: Fri, 29 May 2020 10:31:21 +0800 Subject: [PATCH] cleanup: remove useless methods `BuildArgs` is not used anywhere and the `args` can be directly got from the instance instead of defining a method to do that. Signed-off-by: Dave Chen --- pkg/scheduler/framework/plugins/interpodaffinity/plugin.go | 5 ----- pkg/scheduler/framework/plugins/podtopologyspread/plugin.go | 5 ----- 2 files changed, 10 deletions(-) diff --git a/pkg/scheduler/framework/plugins/interpodaffinity/plugin.go b/pkg/scheduler/framework/plugins/interpodaffinity/plugin.go index b4953ad4397..b3f3eb908e8 100644 --- a/pkg/scheduler/framework/plugins/interpodaffinity/plugin.go +++ b/pkg/scheduler/framework/plugins/interpodaffinity/plugin.go @@ -46,11 +46,6 @@ func (pl *InterPodAffinity) Name() string { return Name } -// BuildArgs returns the args that were used to build the plugin. -func (pl *InterPodAffinity) BuildArgs() interface{} { - return pl.args -} - // New initializes a new plugin and returns it. func New(plArgs runtime.Object, h framework.FrameworkHandle) (framework.Plugin, error) { if h.SnapshotSharedLister() == nil { diff --git a/pkg/scheduler/framework/plugins/podtopologyspread/plugin.go b/pkg/scheduler/framework/plugins/podtopologyspread/plugin.go index 3d70276a03e..a76c9f8abb7 100644 --- a/pkg/scheduler/framework/plugins/podtopologyspread/plugin.go +++ b/pkg/scheduler/framework/plugins/podtopologyspread/plugin.go @@ -58,11 +58,6 @@ func (pl *PodTopologySpread) Name() string { return Name } -// BuildArgs returns the arguments used to build the plugin. -func (pl *PodTopologySpread) BuildArgs() interface{} { - return pl.args -} - // New initializes a new plugin and returns it. func New(plArgs runtime.Object, h framework.FrameworkHandle) (framework.Plugin, error) { if h.SnapshotSharedLister() == nil {