From 452ebed92b6cb08ee1616619efc7e71c2a75c20e Mon Sep 17 00:00:00 2001 From: Janet Kuo Date: Thu, 10 Sep 2015 17:27:03 -0700 Subject: [PATCH] Fix the bug that qos class determination be incorrect with small numbers --- pkg/kubelet/qos/memory_policy.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/kubelet/qos/memory_policy.go b/pkg/kubelet/qos/memory_policy.go index ac542407a90..95e4830f2ac 100644 --- a/pkg/kubelet/qos/memory_policy.go +++ b/pkg/kubelet/qos/memory_policy.go @@ -37,9 +37,9 @@ func isMemoryBestEffort(container *api.Container) bool { func isMemoryGuaranteed(container *api.Container) bool { // A container is memory guaranteed if its memory request == memory limit. // If memory request == memory limit, the user is very confident of resource consumption. - memoryRequestValue := container.Resources.Requests.Memory().Value() - memoryLimitValue := container.Resources.Limits.Memory().Value() - return memoryRequestValue == memoryLimitValue && memoryRequestValue != 0 + memoryRequest := container.Resources.Requests.Memory() + memoryLimit := container.Resources.Limits.Memory() + return (*memoryRequest).Cmp(*memoryLimit) == 0 && memoryRequest.Value() != 0 } // GetContainerOomAdjust returns the amount by which the OOM score of all processes in the