From 45af3ae0cb9ad9055ef605756be32296df373149 Mon Sep 17 00:00:00 2001 From: Han Kang Date: Thu, 16 Jul 2020 09:54:23 -0700 Subject: [PATCH] refactor wrapped functions into variables Change-Id: I1eec309c537920ba520c7a90f9a1f557ec53cf2c --- .../metrics/legacyregistry/registry.go | 36 +++++++------------ 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/staging/src/k8s.io/component-base/metrics/legacyregistry/registry.go b/staging/src/k8s.io/component-base/metrics/legacyregistry/registry.go index 2607f5b2ba0..2605103c10f 100644 --- a/staging/src/k8s.io/component-base/metrics/legacyregistry/registry.go +++ b/staging/src/k8s.io/component-base/metrics/legacyregistry/registry.go @@ -29,6 +29,18 @@ var ( defaultRegistry = metrics.NewKubeRegistry() // DefaultGatherer exposes the global registry gatherer DefaultGatherer metrics.Gatherer = defaultRegistry + // Reset calls reset on the global registry + Reset = defaultRegistry.Reset + // MustRegister registers registerable metrics but uses the global registry. + MustRegister = defaultRegistry.MustRegister + // RawMustRegister registers prometheus collectors but uses the global registry, this + // bypasses the metric stability framework + // + // Deprecated + RawMustRegister = defaultRegistry.RawMustRegister + + // Register registers a collectable metric but uses the global registry + Register = defaultRegistry.Register ) func init() { @@ -54,25 +66,6 @@ func HandlerWithReset() http.Handler { metrics.HandlerWithReset(defaultRegistry, metrics.HandlerOpts{})) } -// Register registers a collectable metric but uses the global registry -func Register(c metrics.Registerable) error { - err := defaultRegistry.Register(c) - return err -} - -// MustRegister registers registerable metrics but uses the global registry. -func MustRegister(cs ...metrics.Registerable) { - defaultRegistry.MustRegister(cs...) -} - -// RawMustRegister registers prometheus collectors but uses the global registry, this -// bypasses the metric stability framework -// -// Deprecated -func RawMustRegister(cs ...prometheus.Collector) { - defaultRegistry.RawMustRegister(cs...) -} - // CustomRegister registers a custom collector but uses the global registry. func CustomRegister(c metrics.StableCollector) error { err := defaultRegistry.CustomRegister(c) @@ -91,8 +84,3 @@ func CustomMustRegister(cs ...metrics.StableCollector) { prometheus.MustRegister(c) } } - -// Reset calls reset on the global registry -func Reset() { - defaultRegistry.Reset() -}