github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-01-06 16:06:51 +00:00
Code Issues Projects Releases Wiki Activity

Augment logs in runContainer path

Browse Source 
Generating errors that are useful is hard.
This commit is contained in:
Tim Hockin
2016-01-25 16:31:32 -08:00
parent 99f301d0b7
commit 45e5912c3d
2 changed files with 19 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/kubelet/dockertools/manager_test.go
View File

@@ -1777,7 +1777,7 @@ func TestVerifyNonRoot(t *testing.T) {
User: "foo",
},
},
expectedError: "unable to validate image is non-root, non-numeric user",
expectedError: "non-numeric user",
},
"numeric root image user": {
container: &api.Container{},
@@ -1812,10 +1812,10 @@ func TestVerifyNonRoot(t *testing.T) {
fakeDocker.Image = v.inspectImage
err := dm.verifyNonRoot(v.container)
if v.expectedError == "" && err != nil {
t.Errorf("%s had unexpected error %v", k, err)
t.Errorf("case[%q]: unexpected error: %v", k, err)
}
if v.expectedError != "" && !strings.Contains(err.Error(), v.expectedError) {
t.Errorf("%s expected error %s but received %s", k, v.expectedError, err.Error())
t.Errorf("case[%q]: expected: %q, got: %q", k, v.expectedError, err.Error())
}
}
}