From 45fc1f0d93b996b0bc84cdcaec47ff60b8c21b4d Mon Sep 17 00:00:00 2001 From: Sam Snarr Date: Thu, 27 Oct 2022 22:18:42 -0400 Subject: [PATCH] fixed test to fail when you change the `expectPluginArgs` so that it is different than `args` --- staging/src/k8s.io/kubectl/pkg/cmd/cmd_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/cmd_test.go b/staging/src/k8s.io/kubectl/pkg/cmd/cmd_test.go index acea4813067..0f8a6997efb 100644 --- a/staging/src/k8s.io/kubectl/pkg/cmd/cmd_test.go +++ b/staging/src/k8s.io/kubectl/pkg/cmd/cmd_test.go @@ -23,6 +23,8 @@ import ( "reflect" "testing" + "github.com/google/go-cmp/cmp" + "github.com/google/go-cmp/cmp/cmpopts" "github.com/spf13/cobra" "k8s.io/cli-runtime/pkg/genericclioptions" ) @@ -143,7 +145,7 @@ func TestKubectlCommandHandlesPlugins(t *testing.T) { t.Fatalf("unexpected plugin execution: expected %q, got %q", test.expectPlugin, pluginsHandler.executedPlugin) } - if len(pluginsHandler.withArgs) != len(test.expectPluginArgs) { + if !cmp.Equal(pluginsHandler.withArgs, test.expectPluginArgs, cmpopts.EquateEmpty()) { t.Fatalf("unexpected plugin execution args: expected %q, got %q", test.expectPluginArgs, pluginsHandler.withArgs) } })