github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #19187 from wojtek-t/add_sleep_in_etcd_server

Browse Source 
Add sleep to EtcdTestServer Terminate.
This commit is contained in:
Marek Grabowski 2016-01-04 19:29:34 +01:00
commit 4606171ad0
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/storage/etcd/testing/utils.go
View File

@ -146,6 +146,13 @@ func (m *EtcdTestServer) waitUntilUp() error {
func (m *EtcdTestServer) Terminate(t *testing.T) { func (m *EtcdTestServer) Terminate(t *testing.T) {
m.Client = nil m.Client = nil
m.s.Stop() m.s.Stop()
// TODO: This is a pretty ugly hack to workaround races during closing
// in-memory etcd server in unit tests - see #18928 for more details.
// We should get rid of it as soon as we have a proper fix - etcd clients
// have overwritten transport counting opened connections (probably by
// overwriting Dial function) and termination function waiting for all
// connections to be closed and stopping accepting new ones.
time.Sleep(250 * time.Millisecond)
for _, hs := range m.hss { for _, hs := range m.hss {
hs.CloseClientConnections() hs.CloseClientConnections()
hs.Close() hs.Close()