From 460f796bb70d67881a71575e4ae510d382a613e7 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Wed, 2 Nov 2022 14:53:43 +0100 Subject: [PATCH] e2e: fix ginkgo parameter setup This is a fix for 104aab81a4b72004090274627f6b01246d334b86: because the default was not set for E2E_TEST_DEBUG_TOOL, all parameters were always also passed to the E2E suite. That wasn't wrong for the parameters so far, but breaks when using something like --output-dir which is only understood by the CLI. --- hack/ginkgo-e2e.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/ginkgo-e2e.sh b/hack/ginkgo-e2e.sh index 64914ea4006..b621813932a 100755 --- a/hack/ginkgo-e2e.sh +++ b/hack/ginkgo-e2e.sh @@ -192,7 +192,7 @@ esac # Move Ginkgo arguments that are understood by the suite when not using # the CLI. suite_args=() -if [ "${E2E_TEST_DEBUG_TOOL}" != "ginkgo" ]; then +if [ "${E2E_TEST_DEBUG_TOOL:-ginkgo}" != "ginkgo" ]; then for arg in "${ginkgo_args[@]}"; do suite_args+=("--ginkgo.${arg#--}") done