github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 20:17:41 +00:00
Code Issues Projects Releases Wiki Activity

Check uper limit of port and ensure 0 corresponds to random port

Browse Source
This commit is contained in:
Konstantinos Tsakalozos 2017-05-23 16:15:49 +03:00
parent 1ffcba7d83
commit 462b8d87cc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
federation/pkg/kubefed/init/init.go
View File

@ -237,7 +237,7 @@ func (i *initFederation) Complete(cmd *cobra.Command, args []string) error {
return fmt.Errorf("%s should be passed only with '%s=NodePort'", apiserverPortFlag, apiserverServiceTypeFlag) return fmt.Errorf("%s should be passed only with '%s=NodePort'", apiserverPortFlag, apiserverServiceTypeFlag)
} }
} }
if i.options.apiServerNodePortsPort < 0 { if i.options.apiServerNodePortsPort < 0 || i.options.apiServerNodePortsPort > 65535 {
return fmt.Errorf("Please provide a valid port number for %s", apiserverPortFlag) return fmt.Errorf("Please provide a valid port number for %s", apiserverPortFlag)
} }
@ -461,7 +461,7 @@ func createService(cmdOut io.Writer, clientset client.Interface, namespace, svcN
Port: 443, Port: 443,
TargetPort: intstr.FromString(apiServerSecurePortName), TargetPort: intstr.FromString(apiServerSecurePortName),
} }
if apiserverServiceType == v1.ServiceTypeNodePort { if apiserverServiceType == v1.ServiceTypeNodePort && apiserverPort > 0 {
port.NodePort = apiserverPort port.NodePort = apiserverPort
} }
svc := &api.Service{ svc := &api.Service{