Comment out calls to httptest.Server.Close()

This commit is contained in:
Wojciech Tyczynski 2016-02-15 12:53:02 +01:00
parent 48caef3576
commit 463d21f352
4 changed files with 18 additions and 9 deletions

View File

@ -39,7 +39,8 @@ import (
func TestClient(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
ns := api.NamespaceDefault
framework.DeleteAllEtcdKeys()
@ -109,7 +110,8 @@ func TestClient(t *testing.T) {
func TestSingleWatch(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
ns := "blargh"
deleteAllEtcdKeys()
@ -194,7 +196,8 @@ func TestMultiWatch(t *testing.T) {
framework.DeleteAllEtcdKeys()
defer framework.DeleteAllEtcdKeys()
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
ns := api.NamespaceDefault
client := client.NewOrDie(&client.Config{Host: s.URL, ContentConfig: client.ContentConfig{GroupVersion: testapi.Default.GroupVersion()}})

View File

@ -31,7 +31,8 @@ import (
func TestExperimentalPrefix(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
resp, err := http.Get(s.URL + "/apis/extensions/")
if err != nil {
@ -44,7 +45,8 @@ func TestExperimentalPrefix(t *testing.T) {
func TestWatchSucceedsWithoutArgs(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
resp, err := http.Get(s.URL + "/api/v1/namespaces?watch=1")
if err != nil {
@ -58,7 +60,8 @@ func TestWatchSucceedsWithoutArgs(t *testing.T) {
func TestAccept(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
resp, err := http.Get(s.URL + "/api/")
if err != nil {

View File

@ -86,7 +86,8 @@ func checkForExpectedMetrics(t *testing.T, metrics []*prometheuspb.MetricFamily,
func TestMasterProcessMetrics(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
metrics, err := scrapeMetrics(s)
if err != nil {
@ -103,7 +104,8 @@ func TestMasterProcessMetrics(t *testing.T) {
func TestApiserverMetrics(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
// Make a request to the apiserver to ensure there's at least one data point
// for the metrics we're expecting -- otherwise, they won't be exported.

View File

@ -43,7 +43,8 @@ func init() {
func TestPersistentVolumeRecycler(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
deleteAllEtcdKeys()
// Use higher QPS and Burst, there is a test for race condition below, which