diff --git a/test/e2e/storage/csi_volumes.go b/test/e2e/storage/csi_volumes.go index f6bb547135a..5ddd5972909 100644 --- a/test/e2e/storage/csi_volumes.go +++ b/test/e2e/storage/csi_volumes.go @@ -31,7 +31,6 @@ import ( csiclient "k8s.io/csi-api/pkg/client/clientset/versioned" "k8s.io/kubernetes/test/e2e/framework" "k8s.io/kubernetes/test/e2e/storage/drivers" - "k8s.io/kubernetes/test/e2e/storage/testpatterns" "k8s.io/kubernetes/test/e2e/storage/testsuites" "k8s.io/kubernetes/test/e2e/storage/utils" imageutils "k8s.io/kubernetes/test/utils/image" @@ -62,27 +61,13 @@ var csiTestSuites = []func() testsuites.TestSuite{ testsuites.InitSnapshottableTestSuite, } -func csiTunePattern(patterns []testpatterns.TestPattern) []testpatterns.TestPattern { - tunedPatterns := []testpatterns.TestPattern{} - - for _, pattern := range patterns { - // Skip inline volume and pre-provsioned PV tests for csi drivers - if pattern.VolType == testpatterns.InlineVolume || pattern.VolType == testpatterns.PreprovisionedPV { - continue - } - tunedPatterns = append(tunedPatterns, pattern) - } - - return tunedPatterns -} - // This executes testSuites for csi volumes. var _ = utils.SIGDescribe("CSI Volumes", func() { for _, initDriver := range csiTestDrivers { curDriver := initDriver() Context(testsuites.GetDriverNameWithFeatureTags(curDriver), func() { - testsuites.DefineTestSuite(curDriver, csiTestSuites, csiTunePattern) + testsuites.DefineTestSuite(curDriver, csiTestSuites) }) } diff --git a/test/e2e/storage/in_tree_volumes.go b/test/e2e/storage/in_tree_volumes.go index f9b7c97901d..23ceaa3c860 100644 --- a/test/e2e/storage/in_tree_volumes.go +++ b/test/e2e/storage/in_tree_volumes.go @@ -19,7 +19,6 @@ package storage import ( . "github.com/onsi/ginkgo" "k8s.io/kubernetes/test/e2e/storage/drivers" - "k8s.io/kubernetes/test/e2e/storage/testpatterns" "k8s.io/kubernetes/test/e2e/storage/testsuites" "k8s.io/kubernetes/test/e2e/storage/utils" ) @@ -58,17 +57,13 @@ var testSuites = []func() testsuites.TestSuite{ testsuites.InitProvisioningTestSuite, } -func intreeTunePattern(patterns []testpatterns.TestPattern) []testpatterns.TestPattern { - return patterns -} - // This executes testSuites for in-tree volumes. var _ = utils.SIGDescribe("In-tree Volumes", func() { for _, initDriver := range testDrivers { curDriver := initDriver() Context(testsuites.GetDriverNameWithFeatureTags(curDriver), func() { - testsuites.DefineTestSuite(curDriver, testSuites, intreeTunePattern) + testsuites.DefineTestSuite(curDriver, testSuites) }) } }) diff --git a/test/e2e/storage/testsuites/base.go b/test/e2e/storage/testsuites/base.go index 96e2ff16674..85dd8347c6f 100644 --- a/test/e2e/storage/testsuites/base.go +++ b/test/e2e/storage/testsuites/base.go @@ -67,12 +67,10 @@ func getTestNameStr(suite TestSuite, pattern testpatterns.TestPattern) string { } // DefineTestSuite defines tests for all testpatterns and all testSuites for a driver -func DefineTestSuite(driver TestDriver, tsInits []func() TestSuite, tunePatternFunc func([]testpatterns.TestPattern) []testpatterns.TestPattern) { +func DefineTestSuite(driver TestDriver, tsInits []func() TestSuite) { for _, testSuiteInit := range tsInits { suite := testSuiteInit() - patterns := tunePatternFunc(suite.getTestSuiteInfo().testPatterns) - - for _, pattern := range patterns { + for _, pattern := range suite.getTestSuiteInfo().testPatterns { p := pattern Context(getTestNameStr(suite, p), func() { BeforeEach(func() {