From 5c288a77fe701b20b79daa949e60d086bff22498 Mon Sep 17 00:00:00 2001 From: Matt Freeman Date: Sun, 29 May 2016 19:44:20 +0700 Subject: [PATCH] Fix error handling in endpoint controller Added missing returns, subsequent statements depend on key --- pkg/controller/endpoint/endpoints_controller.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/controller/endpoint/endpoints_controller.go b/pkg/controller/endpoint/endpoints_controller.go index 257ecb3df1d..6b91b644e88 100644 --- a/pkg/controller/endpoint/endpoints_controller.go +++ b/pkg/controller/endpoint/endpoints_controller.go @@ -273,6 +273,7 @@ func (e *EndpointController) deletePod(obj interface{}) { podKey, err := keyFunc(obj) if err != nil { glog.Errorf("Couldn't get key for object %+v: %v", obj, err) + return } glog.Infof("Pod %q was deleted but we don't have a record of its final state, so it will take up to %v before it will be removed from all endpoint records.", podKey, FullServiceResyncPeriod) @@ -284,6 +285,7 @@ func (e *EndpointController) enqueueService(obj interface{}) { key, err := keyFunc(obj) if err != nil { glog.Errorf("Couldn't get key for object %+v: %v", obj, err) + return } e.queue.Add(key)