Fix some golint failures

This commit is contained in:
wojtekt 2019-07-25 20:38:28 +02:00
parent 117a0e525d
commit 467f5e96ee
5 changed files with 7 additions and 4 deletions

View File

@ -93,7 +93,7 @@ func NewStorage(optsGetter generic.RESTOptionsGetter, kubeletClientConfig client
options := &generic.StoreOptions{ options := &generic.StoreOptions{
RESTOptions: optsGetter, RESTOptions: optsGetter,
AttrFunc: node.GetAttrs, AttrFunc: node.GetAttrs,
TriggerFunc: map[string]storage.IndexerFunc{"metadata.name": node.NodeNameTriggerFunc}, TriggerFunc: map[string]storage.IndexerFunc{"metadata.name": node.NameTriggerFunc},
} }
if err := store.CompleteWithOptions(options); err != nil { if err := store.CompleteWithOptions(options); err != nil {
return nil, err return nil, err

View File

@ -225,7 +225,8 @@ func MatchNode(label labels.Selector, field fields.Selector) pkgstorage.Selectio
} }
} }
func NodeNameTriggerFunc(obj runtime.Object) string { // NameTriggerFunc returns value metadata.namespace of given object.
func NameTriggerFunc(obj runtime.Object) string {
return obj.(*api.Node).ObjectMeta.Name return obj.(*api.Node).ObjectMeta.Name
} }

View File

@ -203,6 +203,7 @@ func MatchPod(label labels.Selector, field fields.Selector) storage.SelectionPre
} }
} }
// NodeNameTriggerFunc returns value spec.nodename of given object.
func NodeNameTriggerFunc(obj runtime.Object) string { func NodeNameTriggerFunc(obj runtime.Object) string {
return obj.(*api.Pod).Spec.NodeName return obj.(*api.Pod).Spec.NodeName
} }

View File

@ -50,7 +50,7 @@ func NewREST(optsGetter generic.RESTOptionsGetter) *REST {
options := &generic.StoreOptions{ options := &generic.StoreOptions{
RESTOptions: optsGetter, RESTOptions: optsGetter,
AttrFunc: secret.GetAttrs, AttrFunc: secret.GetAttrs,
TriggerFunc: map[string]storage.IndexerFunc{"metadata.name": secret.SecretNameTriggerFunc}, TriggerFunc: map[string]storage.IndexerFunc{"metadata.name": secret.NameTriggerFunc},
} }
if err := store.CompleteWithOptions(options); err != nil { if err := store.CompleteWithOptions(options); err != nil {
panic(err) // TODO: Propagate error up panic(err) // TODO: Propagate error up

View File

@ -116,7 +116,8 @@ func Matcher(label labels.Selector, field fields.Selector) pkgstorage.SelectionP
} }
} }
func SecretNameTriggerFunc(obj runtime.Object) string { // NameTriggerFunc returns value metadata.namespace of given object.
func NameTriggerFunc(obj runtime.Object) string {
return obj.(*api.Secret).ObjectMeta.Name return obj.(*api.Secret).ObjectMeta.Name
} }