Merge pull request #96883 from pacoxu/fix/96862

fix index test: multi index check for empty list
This commit is contained in:
Kubernetes Prow Robot 2020-12-15 19:32:20 -08:00 committed by GitHub
commit 46d481b455
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -76,7 +76,7 @@ func TestMultiIndexKeys(t *testing.T) {
expected["bert"] = sets.NewString("one", "two") expected["bert"] = sets.NewString("one", "two")
expected["elmo"] = sets.NewString("tre") expected["elmo"] = sets.NewString("tre")
expected["oscar"] = sets.NewString("two") expected["oscar"] = sets.NewString("two")
expected["elmo"] = sets.NewString() // let's just make sure we don't get anything back in this case expected["elmo1"] = sets.NewString()
{ {
for k, v := range expected { for k, v := range expected {
found := sets.String{} found := sets.String{}
@ -87,9 +87,8 @@ func TestMultiIndexKeys(t *testing.T) {
for _, item := range indexResults { for _, item := range indexResults {
found.Insert(item.(*v1.Pod).Name) found.Insert(item.(*v1.Pod).Name)
} }
items := v.List() if !found.Equal(v) {
if !found.HasAll(items...) { t.Errorf("missing items, index %s, expected %v but found %v", k, v.List(), found.List())
t.Errorf("missing items, index %s, expected %v but found %v", k, items, found.List())
} }
} }
} }