From 2c118356126228801bce0f49921a834eca89562a Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Fri, 17 Apr 2015 00:55:26 -0400 Subject: [PATCH] `kubectl get rc,pods` should invoke in that order SplitResourceArguments should not use a golang map --- pkg/kubectl/resource/builder.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/pkg/kubectl/resource/builder.go b/pkg/kubectl/resource/builder.go index 7e7aceaa23f..b4487bc9914 100644 --- a/pkg/kubectl/resource/builder.go +++ b/pkg/kubectl/resource/builder.go @@ -587,8 +587,16 @@ func (b *Builder) Do() *Result { return r } +// SplitResourceArgument splits the argument with commas and returns unique +// strings in the original order. func SplitResourceArgument(arg string) []string { + out := []string{} set := util.NewStringSet() - set.Insert(strings.Split(arg, ",")...) - return set.List() + for _, s := range strings.Split(arg, ",") { + if set.Has(s) { + continue + } + out = append(out, s) + } + return out }