github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-20 10:20:51 +00:00
Code Issues Projects Releases Wiki Activity

add test to dry-run for unwanted generated values

Browse Source 
[kep 576, dry
run](https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/576-dry-run/README.md#generated-values), states:

```
The UID and the generated name would have a different value in a dry-run and non-dry-run creation. These values will be left empty when performing a dry-run.
```

and

```
ResourceVersion will also be left empty on creation
```

This tests ensures this behavior.
This commit is contained in:
Joe Julian 2021-12-14 17:11:54 -08:00
parent 6845df1729
commit 48994c1518
No known key found for this signature in database
GPG Key ID: FAB12BE0575D999B
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/integration/dryrun/dryrun_test.go
View File

@ -46,16 +46,33 @@ var kindAllowList = sets.NewString()
// namespace used for all tests, do not change this
const testNamespace = "dryrunnamespace"
func DryRunCreateWithGenerateNameTest(t *testing.T, rsc dynamic.ResourceInterface, obj *unstructured.Unstructured, gvResource schema.GroupVersionResource) {
// Create a new object with generateName
gnObj := obj.DeepCopy()
gnObj.SetGenerateName(obj.GetName() + "-")
gnObj.SetName("")
DryRunCreateTest(t, rsc, gnObj, gvResource)
}
func DryRunCreateTest(t *testing.T, rsc dynamic.ResourceInterface, obj *unstructured.Unstructured, gvResource schema.GroupVersionResource) {
createdObj, err := rsc.Create(context.TODO(), obj, metav1.CreateOptions{DryRun: []string{metav1.DryRunAll}})
if err != nil {
t.Fatalf("failed to dry-run create stub for %s: %#v", gvResource, err)
t.Fatalf("failed to dry-run create stub for %s: %#v: %v", gvResource, err, obj)
}
if obj.GroupVersionKind() != createdObj.GroupVersionKind() {
t.Fatalf("created object doesn't have the same gvk as original object: got %v, expected %v",
createdObj.GroupVersionKind(),
obj.GroupVersionKind())
}
if createdObj.GetUID() != "" {
t.Fatalf("created object shouldn't have a uid: %v", createdObj)
}
if createdObj.GetResourceVersion() != "" {
t.Fatalf("created object shouldn't have a resource version: %v", createdObj)
}
if obj.GetGenerateName() != "" && createdObj.GetName() != "" {
t.Fatalf("created object's name should be an empty string if using GenerateName: %v", createdObj)
}
if _, err := rsc.Get(context.TODO(), obj.GetName(), metav1.GetOptions{}); !apierrors.IsNotFound(err) {
t.Fatalf("object shouldn't exist: %v", err)
@ -282,6 +299,7 @@ func TestDryRun(t *testing.T) {
name := obj.GetName()
DryRunCreateTest(t, rsc, obj, gvResource)
DryRunCreateWithGenerateNameTest(t, rsc, obj, gvResource)
if _, err := rsc.Create(context.TODO(), obj, metav1.CreateOptions{}); err != nil {
t.Fatalf("failed to create stub for %s: %#v", gvResource, err)