github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-10 20:42:26 +00:00
Code Issues Projects Releases Wiki Activity

oom_watcher: fix testifylint failures

Browse Source 
Fixed the following testifylint failures:

oom_watcher_linux_test.go:68:2: require-error: for error assertions use require (testifylint)
  assert.NoError(t, oomWatcher.Start(tCtx, node))
  ^
oom_watcher_linux_test.go:128:2: require-error: for error assertions use require (testifylint)
  assert.NoError(t, oomWatcher.Start(tCtx, node))
  ^
oom_watcher_linux_test.go:165:2: require-error: for error assertions use require (testifylint)
  assert.NoError(t, oomWatcher.Start(tCtx, node))
  ^
This commit is contained in:
Ed Bartosh 2024-11-27 17:11:04 +02:00
parent f622be0333
commit 48ea6fc465
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/kubelet/oom/oom_watcher_linux_test.go
View File

@ -27,6 +27,7 @@ import (
"github.com/google/cadvisor/utils/oomparser" "github.com/google/cadvisor/utils/oomparser"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
) )
type fakeStreamer struct { type fakeStreamer struct {
@ -65,7 +66,7 @@ func TestWatcherRecordsEventsForOomEvents(t *testing.T) {
recorder: fakeRecorder, recorder: fakeRecorder,
oomStreamer: fakeStreamer, oomStreamer: fakeStreamer,
} }
assert.NoError(t, oomWatcher.Start(tCtx, node)) require.NoError(t, oomWatcher.Start(tCtx, node))
eventsRecorded := getRecordedEvents(fakeRecorder, numExpectedOomEvents) eventsRecorded := getRecordedEvents(fakeRecorder, numExpectedOomEvents)
assert.Len(t, eventsRecorded, numExpectedOomEvents) assert.Len(t, eventsRecorded, numExpectedOomEvents)
@ -125,7 +126,7 @@ func TestWatcherRecordsEventsForOomEventsCorrectContainerName(t *testing.T) {
recorder: fakeRecorder, recorder: fakeRecorder,
oomStreamer: fakeStreamer, oomStreamer: fakeStreamer,
} }
assert.NoError(t, oomWatcher.Start(tCtx, node)) require.NoError(t, oomWatcher.Start(tCtx, node))
eventsRecorded := getRecordedEvents(fakeRecorder, numExpectedOomEvents) eventsRecorded := getRecordedEvents(fakeRecorder, numExpectedOomEvents)
assert.Len(t, eventsRecorded, numExpectedOomEvents) assert.Len(t, eventsRecorded, numExpectedOomEvents)
@ -162,7 +163,7 @@ func TestWatcherRecordsEventsForOomEventsWithAdditionalInfo(t *testing.T) {
recorder: fakeRecorder, recorder: fakeRecorder,
oomStreamer: fakeStreamer, oomStreamer: fakeStreamer,
} }
assert.NoError(t, oomWatcher.Start(tCtx, node)) require.NoError(t, oomWatcher.Start(tCtx, node))
eventsRecorded := getRecordedEvents(fakeRecorder, numExpectedOomEvents) eventsRecorded := getRecordedEvents(fakeRecorder, numExpectedOomEvents)