From b64df60dcab9aa8d780370a77e387eb66549ce77 Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:22:25 -0800
Subject: [PATCH 01/11] make build/build-image/rsyncd.sh pass shellcheck

---
 build/build-image/rsyncd.sh | 2 +-
 hack/.shellcheck_failures   | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/build-image/rsyncd.sh b/build/build-image/rsyncd.sh
index 21546e59d48..8c00838be10 100755
--- a/build/build-image/rsyncd.sh
+++ b/build/build-image/rsyncd.sh
@@ -45,7 +45,7 @@ mkdir -p "${CONFDIR}"
 if [[ -f "${PIDFILE}" ]]; then
   PID=$(cat "${PIDFILE}")
   echo "Cleaning up old PID file: ${PIDFILE}"
-  kill $PID &> /dev/null || true
+  kill "${PID}" &> /dev/null || true
   rm "${PIDFILE}"
 fi
 
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index c0cd214d0a6..cfe55784d58 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -1,4 +1,3 @@
-./build/build-image/rsyncd.sh
 ./build/common.sh
 ./build/copy-output.sh
 ./build/lib/release.sh

From 621b78b3f646636aac8ed2cb50c073a892f340f7 Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:24:27 -0800
Subject: [PATCH 02/11] make build/shell.sh pass shellcheck

---
 build/shell.sh            | 2 +-
 hack/.shellcheck_failures | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/shell.sh b/build/shell.sh
index 7572cedbc80..63efc92a61e 100755
--- a/build/shell.sh
+++ b/build/shell.sh
@@ -22,7 +22,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 source "${KUBE_ROOT}/build/common.sh"
 
 KUBE_RUN_COPY_OUTPUT="${KUBE_RUN_COPY_OUTPUT:-n}" "${KUBE_ROOT}/build/run.sh" bash "$@"
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index cfe55784d58..4f0f096f723 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -8,7 +8,6 @@
 ./build/release-in-a-container.sh
 ./build/release.sh
 ./build/run.sh
-./build/shell.sh
 ./build/util.sh
 ./cluster/addons/addon-manager/kube-addons.sh
 ./cluster/addons/fluentd-elasticsearch/es-image/run.sh

From b99045333edd1f55d130cc8ffe1bc2ae38653079 Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:25:52 -0800
Subject: [PATCH 03/11] make build/run.sh pass shellcheck

---
 build/run.sh              | 2 +-
 hack/.shellcheck_failures | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/run.sh b/build/run.sh
index b0465fb6b38..3ecc2dacb77 100755
--- a/build/run.sh
+++ b/build/run.sh
@@ -22,7 +22,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 source "$KUBE_ROOT/build/common.sh"
 
 KUBE_RUN_COPY_OUTPUT="${KUBE_RUN_COPY_OUTPUT:-y}"
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index 4f0f096f723..39527f83d6a 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -7,7 +7,6 @@
 ./build/release-images.sh
 ./build/release-in-a-container.sh
 ./build/release.sh
-./build/run.sh
 ./build/util.sh
 ./cluster/addons/addon-manager/kube-addons.sh
 ./cluster/addons/fluentd-elasticsearch/es-image/run.sh

From caf9d94d697ce327e0c1c3dee71a1f06a6fc918e Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:27:43 -0800
Subject: [PATCH 04/11] make build/release.sh pass shellcheck

---
 build/release.sh          | 2 +-
 hack/.shellcheck_failures | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/release.sh b/build/release.sh
index 9e7876b46c6..20010d29aaa 100755
--- a/build/release.sh
+++ b/build/release.sh
@@ -25,7 +25,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 source "${KUBE_ROOT}/build/common.sh"
 source "${KUBE_ROOT}/build/lib/release.sh"
 
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index 39527f83d6a..594ff7a8da8 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -6,7 +6,6 @@
 ./build/package-tarballs.sh
 ./build/release-images.sh
 ./build/release-in-a-container.sh
-./build/release.sh
 ./build/util.sh
 ./cluster/addons/addon-manager/kube-addons.sh
 ./cluster/addons/fluentd-elasticsearch/es-image/run.sh

From 4aa7126ee1b53511ea63479fc116c407c7e26640 Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:29:09 -0800
Subject: [PATCH 05/11] make build/release-images.sh pass shellcheck

---
 build/release-images.sh   | 2 +-
 hack/.shellcheck_failures | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/release-images.sh b/build/release-images.sh
index 3e02293eb75..1f15bd01e3a 100755
--- a/build/release-images.sh
+++ b/build/release-images.sh
@@ -21,7 +21,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 source "${KUBE_ROOT}/build/common.sh"
 source "${KUBE_ROOT}/build/lib/release.sh"
 
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index 594ff7a8da8..c52a1c9d1fc 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -4,7 +4,6 @@
 ./build/make-build-image.sh
 ./build/make-clean.sh
 ./build/package-tarballs.sh
-./build/release-images.sh
 ./build/release-in-a-container.sh
 ./build/util.sh
 ./cluster/addons/addon-manager/kube-addons.sh

From eba69c5267a217497ab66d86388732a6c905cc0d Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:31:15 -0800
Subject: [PATCH 06/11] make build/release-in-a-container.sh pass shellcheck

---
 build/release-in-a-container.sh | 4 ++--
 hack/.shellcheck_failures       | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/build/release-in-a-container.sh b/build/release-in-a-container.sh
index a160fe927b6..e21d2ad17d9 100755
--- a/build/release-in-a-container.sh
+++ b/build/release-in-a-container.sh
@@ -18,7 +18,7 @@ set -o nounset
 set -o pipefail
 
 # Complete the release with the standard env
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 
 # Check and error if not "in-a-container"
 if [[ ! -f /.dockerenv ]]; then
@@ -46,4 +46,4 @@ if [[ $KUBE_RELEASE_RUN_TESTS =~ ^[yY]$ ]]; then
   make test
 fi
 
-$KUBE_ROOT/build/package-tarballs.sh
+"${KUBE_ROOT}/build/package-tarballs.sh"
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index c52a1c9d1fc..34a50fc5c61 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -4,7 +4,6 @@
 ./build/make-build-image.sh
 ./build/make-clean.sh
 ./build/package-tarballs.sh
-./build/release-in-a-container.sh
 ./build/util.sh
 ./cluster/addons/addon-manager/kube-addons.sh
 ./cluster/addons/fluentd-elasticsearch/es-image/run.sh

From 2d6ead8c7dd6e69d97efb00c55e92e7b1a04d9b1 Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:32:28 -0800
Subject: [PATCH 07/11] make build/package-tarballs.sh pass shellcheck

---
 build/package-tarballs.sh | 2 +-
 hack/.shellcheck_failures | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/package-tarballs.sh b/build/package-tarballs.sh
index 9432015b85b..0a5b778a446 100755
--- a/build/package-tarballs.sh
+++ b/build/package-tarballs.sh
@@ -18,7 +18,7 @@ set -o nounset
 set -o pipefail
 
 # Complete the release with the standard env
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 source "${KUBE_ROOT}/build/common.sh"
 source "${KUBE_ROOT}/build/lib/release.sh"
 
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index 34a50fc5c61..c6a545ff7e7 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -3,7 +3,6 @@
 ./build/lib/release.sh
 ./build/make-build-image.sh
 ./build/make-clean.sh
-./build/package-tarballs.sh
 ./build/util.sh
 ./cluster/addons/addon-manager/kube-addons.sh
 ./cluster/addons/fluentd-elasticsearch/es-image/run.sh

From 742504db39f51539720899ef6b41c4ca44d41136 Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:33:28 -0800
Subject: [PATCH 08/11] make build/make-clean.sh pass shellcheck

---
 build/make-clean.sh       | 2 +-
 hack/.shellcheck_failures | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/make-clean.sh b/build/make-clean.sh
index af59f33d137..b3f567490a6 100755
--- a/build/make-clean.sh
+++ b/build/make-clean.sh
@@ -19,7 +19,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 source "${KUBE_ROOT}/build/common.sh"
 
 kube::build::verify_prereqs false
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index c6a545ff7e7..b0d83d3f286 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -2,7 +2,6 @@
 ./build/copy-output.sh
 ./build/lib/release.sh
 ./build/make-build-image.sh
-./build/make-clean.sh
 ./build/util.sh
 ./cluster/addons/addon-manager/kube-addons.sh
 ./cluster/addons/fluentd-elasticsearch/es-image/run.sh

From b5767bcf89c0d0bdf689b166ff694c94710b2d9c Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:34:36 -0800
Subject: [PATCH 09/11] make build/make-build-image.sh pass shellcheck

---
 build/make-build-image.sh | 2 +-
 hack/.shellcheck_failures | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/make-build-image.sh b/build/make-build-image.sh
index 8ad0e3bbd31..9c7ba3a603f 100755
--- a/build/make-build-image.sh
+++ b/build/make-build-image.sh
@@ -24,7 +24,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-KUBE_ROOT="$(dirname "${BASH_SOURCE}")/.."
+KUBE_ROOT="$(dirname "${BASH_SOURCE[0]}")/.."
 source "${KUBE_ROOT}/build/common.sh"
 
 kube::build::verify_prereqs
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index b0d83d3f286..0ed57b71da4 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -1,7 +1,6 @@
 ./build/common.sh
 ./build/copy-output.sh
 ./build/lib/release.sh
-./build/make-build-image.sh
 ./build/util.sh
 ./cluster/addons/addon-manager/kube-addons.sh
 ./cluster/addons/fluentd-elasticsearch/es-image/run.sh

From f41efc3ea8d001d132f7a45f0a839f595e0290b4 Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:37:13 -0800
Subject: [PATCH 10/11] make build/util.sh pass shellcheck

---
 build/util.sh             | 8 ++++----
 hack/.shellcheck_failures | 1 -
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/build/util.sh b/build/util.sh
index 32152ff9214..cfa88fc5299 100644
--- a/build/util.sh
+++ b/build/util.sh
@@ -16,17 +16,17 @@
 
 # Common utility functions for build scripts
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 
 function kube::release::semantic_version() {
   # This takes:
   # Client Version: version.Info{Major:"1", Minor:"1+", GitVersion:"v1.1.0-alpha.0.2328+3c0a05de4a38e3", GitCommit:"3c0a05de4a38e355d147dbfb4d85bad6d2d73bb9", GitTreeState:"clean"}
   # and spits back the GitVersion piece in a way that is somewhat
   # resilient to the other fields changing (we hope)
-  ${KUBE_ROOT}/cluster/kubectl.sh version --client | sed "s/, */\\
-/g" | egrep "^GitVersion:" | cut -f2 -d: | cut -f2 -d\"
+  "${KUBE_ROOT}/cluster/kubectl.sh" version --client | sed "s/, */\\
+/g" | grep -E "^GitVersion:" | cut -f2 -d: | cut -f2 -d\"
 }
 
 function kube::release::semantic_image_tag_version() {
-    printf "$(kube::release::semantic_version)" | tr + _
+    printf "%s" "$(kube::release::semantic_version)" | tr + _
 }
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index 0ed57b71da4..165be127c15 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -1,7 +1,6 @@
 ./build/common.sh
 ./build/copy-output.sh
 ./build/lib/release.sh
-./build/util.sh
 ./cluster/addons/addon-manager/kube-addons.sh
 ./cluster/addons/fluentd-elasticsearch/es-image/run.sh
 ./cluster/addons/fluentd-elasticsearch/fluentd-es-image/run.sh

From b716edb2846bc361e14e5d737e8f8f18096c3321 Mon Sep 17 00:00:00 2001
From: Benjamin Elder <bentheelder@google.com>
Date: Wed, 16 Jan 2019 00:39:13 -0800
Subject: [PATCH 11/11] make build/copy-output.sh pass shellcheck

---
 build/copy-output.sh      | 2 +-
 hack/.shellcheck_failures | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/build/copy-output.sh b/build/copy-output.sh
index 8b189224347..5829e81f49b 100755
--- a/build/copy-output.sh
+++ b/build/copy-output.sh
@@ -19,7 +19,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
 source "${KUBE_ROOT}/build/common.sh"
 
 kube::build::verify_prereqs
diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index 165be127c15..c35cbe8600d 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -1,5 +1,4 @@
 ./build/common.sh
-./build/copy-output.sh
 ./build/lib/release.sh
 ./cluster/addons/addon-manager/kube-addons.sh
 ./cluster/addons/fluentd-elasticsearch/es-image/run.sh