From 4a380609a94e7ba4d03fbd15b1ec0d4bb8a4ccca Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Tue, 31 Oct 2023 12:32:23 +0100 Subject: [PATCH] serviceaccount: fix incorrect usage of %w in Errorf Found by govet in combination with new klog where printf-style checking is enabled. --- pkg/serviceaccount/legacy.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/serviceaccount/legacy.go b/pkg/serviceaccount/legacy.go index 43f2f1f77af..f05c4d1b171 100644 --- a/pkg/serviceaccount/legacy.go +++ b/pkg/serviceaccount/legacy.go @@ -193,10 +193,10 @@ func (v *legacyValidator) patchSecretWithLastUsedDate(ctx context.Context, secre if lastUsed != today && lastUsed != tomorrow { patchContent, err := json.Marshal(applyv1.Secret(secret.Name, secret.Namespace).WithUID(secret.UID).WithLabels(map[string]string{LastUsedLabelKey: today})) if err != nil { - klog.Errorf("Failed to marshal legacy service account token %s/%s tracking labels, err: %w", secret.Name, secret.Namespace, err) + klog.Errorf("Failed to marshal legacy service account token %s/%s tracking labels, err: %v", secret.Name, secret.Namespace, err) } else { if _, err := v.secretsWriter.Secrets(secret.Namespace).Patch(ctx, secret.Name, types.MergePatchType, patchContent, metav1.PatchOptions{}); err != nil { - klog.Errorf("Failed to label legacy service account token %s/%s with last-used date, err: %w", secret.Name, secret.Namespace, err) + klog.Errorf("Failed to label legacy service account token %s/%s with last-used date, err: %v", secret.Name, secret.Namespace, err) } } }