From 4a5a242a68d11abf16ca2fb6f91ed92e88e001e9 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Wed, 28 Jun 2023 15:18:14 +0200 Subject: [PATCH] dra e2e: using logging for background activity ginkgo.By should be used for steps in the test flow. Creating and deleting CDI files happens in parallel to that. If reported via ginkgo.By, progress reports look weird because they contain e.g. step "waiting for...." (from the main test, which is still on-going) and end with "creating CDI file" (which is already completed). --- test/e2e/dra/deploy.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/dra/deploy.go b/test/e2e/dra/deploy.go index a7583462d67..6d762b13c28 100644 --- a/test/e2e/dra/deploy.go +++ b/test/e2e/dra/deploy.go @@ -214,11 +214,11 @@ func (d *Driver) SetUp(nodes *Nodes, resources app.Resources) { plugin, err := app.StartPlugin(logger, "/cdi", d.Name, nodename, app.FileOperations{ Create: func(name string, content []byte) error { - ginkgo.By(fmt.Sprintf("creating CDI file %s on node %s:\n%s", name, nodename, string(content))) + klog.Background().Info("creating CDI file", "node", nodename, "filename", name, "content", string(content)) return d.createFile(&pod, name, content) }, Remove: func(name string) error { - ginkgo.By(fmt.Sprintf("deleting CDI file %s on node %s", name, nodename)) + klog.Background().Info("deleting CDI file", "node", nodename, "filename", name) return d.removeFile(&pod, name) }, },