github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 17:30:00 +00:00
Code Issues Projects Releases Wiki Activity

make test a bit more generic

Browse Source
This commit is contained in:
Dan Winship 2020-03-12 14:52:34 -04:00 committed by Dan Winship
parent ddebbfd806
commit 4a7c86c105
1 changed files with 27 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
pkg/registry/core/service/ipallocator/allocator_test.go
View File

@ -30,29 +30,34 @@ func TestAllocate(t *testing.T) {
cidr string cidr string
free int free int
released string released string
outOfRange1 string outOfRange []string
outOfRange2 string
outOfRange3 string
alreadyAllocated string alreadyAllocated string
}{ }{
{ {
name: "IPv4", name: "IPv4",
cidr: "192.168.1.0/24", cidr: "192.168.1.0/24",
free: 254, free: 254,
released: "192.168.1.5", released: "192.168.1.5",
outOfRange1: "192.168.0.1", outOfRange: []string{
outOfRange2: "192.168.1.0", "192.168.0.1", // not in 192.168.1.0/24
outOfRange3: "192.168.1.255", "192.168.1.0", // reserved (base address)
"192.168.1.255", // reserved (broadcast address)
"192.168.2.2", // not in 192.168.1.0/24
},
alreadyAllocated: "192.168.1.1", alreadyAllocated: "192.168.1.1",
}, },
{ {
name: "IPv6", name: "IPv6",
cidr: "2001:db8:1::/48", cidr: "2001:db8:1::/48",
free: 65534, free: 65534,
released: "2001:db8:1::5", released: "2001:db8:1::5",
outOfRange1: "2001:db8::1", outOfRange: []string{
outOfRange2: "2001:db8:1::", "2001:db8::1", // not in 2001:db8:1::/48
outOfRange3: "2001:db8:1::ffff", "2001:db8:1::", // reserved (base address)
"2001:db8:1::ffff", // reserved (broadcast address)
"2001:db8:1::1:0", // not in the low 16 bits of 2001:db8:1::/48
"2001:db8:2::2", // not in 2001:db8:1::/48
},
alreadyAllocated: "2001:db8:1::1", alreadyAllocated: "2001:db8:1::1",
}, },
} }
@ -119,21 +124,15 @@ func TestAllocate(t *testing.T) {
if err := r.Release(released); err != nil { if err := r.Release(released); err != nil {
t.Fatal(err) t.Fatal(err)
} }
err = r.Allocate(net.ParseIP(tc.outOfRange1)) for _, outOfRange := range tc.outOfRange {
if _, ok := err.(*ErrNotInRange); !ok { err = r.Allocate(net.ParseIP(outOfRange))
t.Fatal(err) if _, ok := err.(*ErrNotInRange); !ok {
t.Fatal(err)
}
} }
if err := r.Allocate(net.ParseIP(tc.alreadyAllocated)); err != ErrAllocated { if err := r.Allocate(net.ParseIP(tc.alreadyAllocated)); err != ErrAllocated {
t.Fatal(err) t.Fatal(err)
} }
err = r.Allocate(net.ParseIP(tc.outOfRange2))
if _, ok := err.(*ErrNotInRange); !ok {
t.Fatal(err)
}
err = r.Allocate(net.ParseIP(tc.outOfRange3))
if _, ok := err.(*ErrNotInRange); !ok {
t.Fatal(err)
}
if f := r.Free(); f != 1 { if f := r.Free(); f != 1 {
t.Errorf("Test %s unexpected free %d", tc.name, f) t.Errorf("Test %s unexpected free %d", tc.name, f)
} }