From f7a563435fe9cfab4a3a525df44b3da25a34932a Mon Sep 17 00:00:00 2001 From: Rohit Agarwal Date: Sun, 11 Jun 2017 19:25:32 -0700 Subject: [PATCH] Fix bad check in node e2e tests for GPUs. When no nvidia device was attached, the -ne check had a syntax error: sh: -ne: argument expected This resulted in 'Success' being echoed and the test passing incorrectly. This was found while debugging issue #47216 --- test/e2e_node/gpus.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e_node/gpus.go b/test/e2e_node/gpus.go index 4baa75f34d5..b52ad38c6e1 100644 --- a/test/e2e_node/gpus.go +++ b/test/e2e_node/gpus.go @@ -161,7 +161,7 @@ func makePod(gpus int64, name string) *v1.Pod { v1.ResourceNvidiaGPU: *resource.NewQuantity(gpus, resource.DecimalSI), }, } - gpuverificationCmd := fmt.Sprintf("if [[ %d -ne $(ls /dev/ | egrep '^nvidia[0-9]+$') ]]; then exit 1; fi; echo Success", gpus) + gpuverificationCmd := fmt.Sprintf("if [[ %d -ne $(ls /dev/ | egrep '^nvidia[0-9]+$' | wc -l) ]]; then exit 1; else echo Success; fi", gpus) return &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: name,