From 50387d9d1cca57b9ec6b11e2694eabd5ab46d4e9 Mon Sep 17 00:00:00 2001 From: Mike Kaplinskiy Date: Sun, 29 Oct 2017 17:58:57 -0700 Subject: [PATCH 1/2] Make github hide generated files in diffs https://github.com/github/linguist#generated-code says to add `linguist-generated=true` to any files that you don't want to see diffs in. IMO this will make PRs a little easier to review. e.g. the top half of https://github.com/kubernetes/kubernetes/pull/53988 should disappear --- .gitattributes | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.gitattributes b/.gitattributes index ca340357b87..766d29d855a 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,9 +1,10 @@ hack/verify-flags/known-flags.txt merge=union test/test_owners.csv merge=union -**/zz_generated.*.go -diff -**/types.generated.go -diff -**/generated.pb.go -diff -**/generated.proto -diff -**/types_swagger_doc_generated.go -diff -docs/api-reference/** -diff +**/zz_generated.*.go -diff linguist-generated=true +**/types.generated.go -diff linguist-generated=true +**/generated.pb.go -diff linguist-generated=true +**/generated.proto -diff linguist-generated=true +**/types_swagger_doc_generated.go -diff linguist-generated=true +docs/api-reference/** -diff linguist-generated=true +api/swagger-spec/*.json -diff linguist-generated=true From 4f9f0336665ca0c494b90916d316d91bc053d9b3 Mon Sep 17 00:00:00 2001 From: Mike Kaplinskiy Date: Wed, 1 Nov 2017 15:51:54 -0700 Subject: [PATCH 2/2] Don't hide proto files --- .gitattributes | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitattributes b/.gitattributes index 766d29d855a..2dad50d3c79 100644 --- a/.gitattributes +++ b/.gitattributes @@ -4,7 +4,7 @@ test/test_owners.csv merge=union **/zz_generated.*.go -diff linguist-generated=true **/types.generated.go -diff linguist-generated=true **/generated.pb.go -diff linguist-generated=true -**/generated.proto -diff linguist-generated=true +**/generated.proto -diff **/types_swagger_doc_generated.go -diff linguist-generated=true docs/api-reference/** -diff linguist-generated=true api/swagger-spec/*.json -diff linguist-generated=true