diff --git a/pkg/controller/volume/scheduling/scheduler_assume_cache.go b/pkg/controller/volume/scheduling/scheduler_assume_cache.go index 5f02decb784..68f6fa2cac8 100644 --- a/pkg/controller/volume/scheduling/scheduler_assume_cache.go +++ b/pkg/controller/volume/scheduling/scheduler_assume_cache.go @@ -345,7 +345,7 @@ type PVAssumeCache interface { } type pvAssumeCache struct { - *assumeCache + AssumeCache } func pvStorageClassIndexFunc(obj interface{}) ([]string, error) { @@ -357,7 +357,7 @@ func pvStorageClassIndexFunc(obj interface{}) ([]string, error) { // NewPVAssumeCache creates a PV assume cache. func NewPVAssumeCache(informer cache.SharedIndexInformer) PVAssumeCache { - return &pvAssumeCache{NewAssumeCache(informer, "v1.PersistentVolume", "storageclass", pvStorageClassIndexFunc).(*assumeCache)} + return &pvAssumeCache{NewAssumeCache(informer, "v1.PersistentVolume", "storageclass", pvStorageClassIndexFunc)} } func (c *pvAssumeCache) GetPV(pvName string) (*v1.PersistentVolume, error) { @@ -413,12 +413,12 @@ type PVCAssumeCache interface { } type pvcAssumeCache struct { - *assumeCache + AssumeCache } // NewPVCAssumeCache creates a PVC assume cache. func NewPVCAssumeCache(informer cache.SharedIndexInformer) PVCAssumeCache { - return &pvcAssumeCache{NewAssumeCache(informer, "v1.PersistentVolumeClaim", "namespace", cache.MetaNamespaceIndexFunc).(*assumeCache)} + return &pvcAssumeCache{NewAssumeCache(informer, "v1.PersistentVolumeClaim", "namespace", cache.MetaNamespaceIndexFunc)} } func (c *pvcAssumeCache) GetPVC(pvcKey string) (*v1.PersistentVolumeClaim, error) { diff --git a/pkg/controller/volume/scheduling/scheduler_assume_cache_test.go b/pkg/controller/volume/scheduling/scheduler_assume_cache_test.go index c8b0bf0f327..2fb8b0f8ca3 100644 --- a/pkg/controller/volume/scheduling/scheduler_assume_cache_test.go +++ b/pkg/controller/volume/scheduling/scheduler_assume_cache_test.go @@ -109,7 +109,7 @@ func TestAssumePV(t *testing.T) { for name, scenario := range scenarios { cache := NewPVAssumeCache(nil) - internalCache, ok := cache.(*pvAssumeCache) + internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to get internal cache") } @@ -143,7 +143,7 @@ func TestAssumePV(t *testing.T) { func TestRestorePV(t *testing.T) { cache := NewPVAssumeCache(nil) - internalCache, ok := cache.(*pvAssumeCache) + internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to get internal cache") } @@ -183,7 +183,7 @@ func TestRestorePV(t *testing.T) { func TestBasicPVCache(t *testing.T) { cache := NewPVAssumeCache(nil) - internalCache, ok := cache.(*pvAssumeCache) + internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to get internal cache") } @@ -227,7 +227,7 @@ func TestBasicPVCache(t *testing.T) { func TestPVCacheWithStorageClasses(t *testing.T) { cache := NewPVAssumeCache(nil) - internalCache, ok := cache.(*pvAssumeCache) + internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to get internal cache") } @@ -273,7 +273,7 @@ func TestPVCacheWithStorageClasses(t *testing.T) { func TestAssumeUpdatePVCache(t *testing.T) { cache := NewPVAssumeCache(nil) - internalCache, ok := cache.(*pvAssumeCache) + internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to get internal cache") } @@ -366,7 +366,7 @@ func TestAssumePVC(t *testing.T) { for name, scenario := range scenarios { cache := NewPVCAssumeCache(nil) - internalCache, ok := cache.(*pvcAssumeCache) + internalCache, ok := cache.(*pvcAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to get internal cache") } @@ -400,7 +400,7 @@ func TestAssumePVC(t *testing.T) { func TestRestorePVC(t *testing.T) { cache := NewPVCAssumeCache(nil) - internalCache, ok := cache.(*pvcAssumeCache) + internalCache, ok := cache.(*pvcAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to get internal cache") } @@ -440,7 +440,7 @@ func TestRestorePVC(t *testing.T) { func TestAssumeUpdatePVCCache(t *testing.T) { cache := NewPVCAssumeCache(nil) - internalCache, ok := cache.(*pvcAssumeCache) + internalCache, ok := cache.(*pvcAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to get internal cache") } diff --git a/pkg/controller/volume/scheduling/scheduler_binder_test.go b/pkg/controller/volume/scheduling/scheduler_binder_test.go index 54433369da4..01c0be6fd66 100644 --- a/pkg/controller/volume/scheduling/scheduler_binder_test.go +++ b/pkg/controller/volume/scheduling/scheduler_binder_test.go @@ -103,8 +103,8 @@ type testEnv struct { binder SchedulerVolumeBinder internalBinder *volumeBinder internalNodeInformer coreinformers.NodeInformer - internalPVCache *pvAssumeCache - internalPVCCache *pvcAssumeCache + internalPVCache *assumeCache + internalPVCCache *assumeCache } func newTestBinder(t *testing.T, stopCh <-chan struct{}) *testEnv { @@ -206,13 +206,13 @@ func newTestBinder(t *testing.T, stopCh <-chan struct{}) *testEnv { } pvCache := internalBinder.pvCache - internalPVCache, ok := pvCache.(*pvAssumeCache) + internalPVCache, ok := pvCache.(*pvAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to convert to internal PV cache") } pvcCache := internalBinder.pvcCache - internalPVCCache, ok := pvcCache.(*pvcAssumeCache) + internalPVCCache, ok := pvcCache.(*pvcAssumeCache).AssumeCache.(*assumeCache) if !ok { t.Fatalf("Failed to convert to internal PVC cache") }