github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-10 04:27:54 +00:00
Code Issues Projects Releases Wiki Activity

Add service name tests

Browse Source
This commit is contained in:
Justin Garrison 2023-10-10 22:27:44 +00:00
parent 62267518b8
commit 4acaf9ebed
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/kubelet/kubelet_server_journal_test.go
View File

@ -130,6 +130,10 @@ func Test_validateServices(t *testing.T) {
var ( var (
service1 = "svc1" service1 = "svc1"
service2 = "svc2" service2 = "svc2"
service3 = "svc.foo"
service4 = "svc_foo"
service5 = "svc@foo"
service6 = "svc:foo"
invalid1 = "svc\n" invalid1 = "svc\n"
invalid2 = "svc.foo\n" invalid2 = "svc.foo\n"
) )
@ -140,10 +144,14 @@ func Test_validateServices(t *testing.T) {
}{ }{
{name: "one service", services: []string{service1}}, {name: "one service", services: []string{service1}},
{name: "two services", services: []string{service1, service2}}, {name: "two services", services: []string{service1, service2}},
{name: "dot service", services: []string{service3}},
{name: "underscore service", services: []string{service4}},
{name: "at service", services: []string{service5}},
{name: "colon service", services: []string{service6}},
{name: "invalid service new line", services: []string{invalid1}, wantErr: true}, {name: "invalid service new line", services: []string{invalid1}, wantErr: true},
{name: "invalid service with dot", services: []string{invalid2}, wantErr: true}, {name: "invalid service with dot", services: []string{invalid2}, wantErr: true},
{name: "long service", services: []string{strings.Repeat(service1, 100)}, wantErr: true}, {name: "long service", services: []string{strings.Repeat(service1, 100)}, wantErr: true},
{name: "max number of services", services: []string{service1, service2, service1, service2, service1}, wantErr: true}, {name: "max number of services", services: []string{service1, service2, service3, service4, service5}, wantErr: true},
} }
for _, tt := range tests { for _, tt := range tests {
errs := validateServices(tt.services) errs := validateServices(tt.services)