From 4aef5b8f4c073d24debe8ee85f738a875a8d967e Mon Sep 17 00:00:00 2001 From: Rob Scott Date: Mon, 14 Sep 2020 16:28:01 -0700 Subject: [PATCH] Increasing acceptable timeout for EndpointSlice garbage collection This should help minimize flakiness for these tests. --- test/e2e/network/endpointslice.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/e2e/network/endpointslice.go b/test/e2e/network/endpointslice.go index f22f6b112fa..181e5cc72bd 100644 --- a/test/e2e/network/endpointslice.go +++ b/test/e2e/network/endpointslice.go @@ -144,8 +144,11 @@ var _ = SIGDescribe("EndpointSlice", func() { framework.Failf("Endpoints resource not deleted after Service %s/%s was deleted: %s", svc.Namespace, svc.Name, err) } - // Expect EndpointSlice resource to be deleted when Service is. - if err := wait.PollImmediate(2*time.Second, wait.ForeverTestTimeout, func() (bool, error) { + // Expect EndpointSlice resource to be deleted when Service is. Wait for + // up to 90 seconds since garbage collector only polls every 30 seconds + // and may need to retry informer resync at some point during an e2e + // run. + if err := wait.PollImmediate(2*time.Second, 90*time.Second, func() (bool, error) { endpointSliceList, err := cs.DiscoveryV1beta1().EndpointSlices(svc.Namespace).List(context.TODO(), metav1.ListOptions{ LabelSelector: "kubernetes.io/service-name=" + svc.Name, })