github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 18:24:07 +00:00
Code Issues Projects Releases Wiki Activity

Check sorting of linted file in hack/verify-golint.sh

Browse Source
This commit is contained in:
Dr. Stefan Schimanski 2016-08-22 13:17:47 +02:00
parent 4b949093c2
commit 4b38912ae6
1 changed files with 22 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
hack/verify-golint.sh
View File

@ -37,11 +37,23 @@ array_contains () {
return $in return $in
} }
# Check that the file is in alphabetical order
linted_file="${KUBE_ROOT}/hack/.linted_packages"
if ! diff -u "${linted_file}" <(LANG=C sort "${linted_file}"); then
{
echo
echo "hack/.linted_packages is not in alphabetical order. Please sort it:"
echo
echo " sort -o hack/.linted_packages hack/.linted_packages"
echo
} >&2
false
fi
export IFS=$'\n' export IFS=$'\n'
all_packages=( all_packages=(
$(go list -e ./... | egrep -v "/(third_party|vendor|staging|generated|clientset_generated)" | sed 's/k8s.io\/kubernetes\///g') $(go list -e ./... | egrep -v "/(third_party|vendor|staging|generated|clientset_generated)" | sed 's/k8s.io\/kubernetes\///g')
) )
linted_file="${KUBE_ROOT}/hack/.linted_packages"
linted_packages=( linted_packages=(
$(cat $linted_file) $(cat $linted_file)
) )
@ -78,16 +90,20 @@ else
fi fi
# check to make sure all packages that pass lint are in the linted file. # check to make sure all packages that pass lint are in the linted file.
echo
if [ ${#linted[@]} -eq 0 ]; then if [ ${#linted[@]} -eq 0 ]; then
echo 'Success! All packages that should pass lint are listed in the linted file.' echo 'Success! All packages that should pass lint are listed in the linted file.'
else else
{ {
echo "The following packages passed golint but are not listed in $linted_file:" echo "Some packages passed golint but are not listed in hack/.linted_packages."
for p in "${linted[@]}"; do echo "Please add them in alphabetical order:"
echo "echo $p >> hack/.linted_packages"
done
echo echo
echo 'Please add the following packages to the linted file. You can test via this script and commit the result.' for p in "${linted[@]}"; do
echo " echo $p >> hack/.linted_packages"
done
echo " LANG=C sort -o hack/.linted_packages hack/.linted_packages"
echo
echo 'You can test via this script and commit the result.'
echo echo
} >&2 } >&2
false false