From 85763127c0b9399e6c48ec144c4716543a6cbe2d Mon Sep 17 00:00:00 2001 From: wojtekt Date: Thu, 27 Jun 2019 17:18:56 +0200 Subject: [PATCH] Fix client-go request benchmark --- .../src/k8s.io/client-go/rest/request_test.go | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/staging/src/k8s.io/client-go/rest/request_test.go b/staging/src/k8s.io/client-go/rest/request_test.go index e6a44fc7ae5..d88a0a35288 100755 --- a/staging/src/k8s.io/client-go/rest/request_test.go +++ b/staging/src/k8s.io/client-go/rest/request_test.go @@ -1440,15 +1440,20 @@ func BenchmarkCheckRetryClosesBody(b *testing.B) { defer testServer.Close() c := testRESTClient(b, testServer) - r := c.Verb("POST"). - Prefix("foo", "bar"). - Suffix("baz"). - Timeout(time.Second). - Body([]byte(strings.Repeat("abcd", 1000))) + requests := make([]*Request, 0, b.N) for i := 0; i < b.N; i++ { - if _, err := r.DoRaw(); err != nil { - b.Fatalf("Unexpected error: %v %#v", err, err) + requests = append(requests, c.Verb("POST"). + Prefix("foo", "bar"). + Suffix("baz"). + Timeout(time.Second). + Body([]byte(strings.Repeat("abcd", 1000)))) + } + + b.ResetTimer() + for i := 0; i < b.N; i++ { + if _, err := requests[i].DoRaw(); err != nil { + b.Fatalf("Unexpected error (%d/%d): %v", i, b.N, err) } } }