github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 21:17:23 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #31859 from resouer/fix-nits

Browse Source 
Automatic merge from submit-queue

Fix minor nits in test cases

Found a group of nits when doing #30844, fixed them in a this PR since 30844 requires a long time to review.
This commit is contained in:
Kubernetes Submit Queue 2016-09-18 06:27:12 -07:00 committed by GitHub
commit 4b5c74eed8
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugin/pkg/scheduler/algorithm/predicates/predicates_test.go
View File

@ -747,7 +747,7 @@ func TestPodFitsSelector(t *testing.T) {
}, },
}, },
labels: map[string]string{ labels: map[string]string{
// We use two digit to denote major version and two digit for minior version. // We use two digit to denote major version and two digit for minor version.
"kernel-version": "0206", "kernel-version": "0206",
}, },
fits: true, fits: true,
@ -2619,7 +2619,7 @@ func TestPodToleratesTaints(t *testing.T) {
}, },
}, },
fits: true, fits: true,
test: "a pod which can be scheduled on a dedicated node assgined to user1 with effect NoSchedule", test: "a pod which can be scheduled on a dedicated node assigned to user1 with effect NoSchedule",
}, },
{ {
pod: &api.Pod{ pod: &api.Pod{
@ -2652,7 +2652,7 @@ func TestPodToleratesTaints(t *testing.T) {
}, },
}, },
fits: false, fits: false,
test: "a pod which can't be scheduled on a dedicated node assgined to user2 with effect NoSchedule", test: "a pod which can't be scheduled on a dedicated node assigned to user2 with effect NoSchedule",
}, },
{ {
pod: &api.Pod{ pod: &api.Pod{
@ -2826,7 +2826,7 @@ func TestPodToleratesTaints(t *testing.T) {
}, },
fits: true, fits: true,
test: "The pod has a toleration that key and value don't match the taint on the node, " + test: "The pod has a toleration that key and value don't match the taint on the node, " +
"but the effect of taint on node is PreferNochedule. Pod can be shceduled onto the node", "but the effect of taint on node is PreferNochedule. Pod can be scheduled onto the node",
}, },
} }
expectedFailureReasons := []algorithm.PredicateFailureReason{ErrTaintsTolerationsNotMatch} expectedFailureReasons := []algorithm.PredicateFailureReason{ErrTaintsTolerationsNotMatch}