From 4b85e02504adbe7cd8b7b802796fe7e713792724 Mon Sep 17 00:00:00 2001 From: Dawn Chen Date: Wed, 1 Jul 2015 16:37:14 -0700 Subject: [PATCH] Set minimal shares for containers with no cpu specified --- pkg/kubelet/dockertools/docker.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/kubelet/dockertools/docker.go b/pkg/kubelet/dockertools/docker.go index d0945931aaf..7f7b9169c4d 100644 --- a/pkg/kubelet/dockertools/docker.go +++ b/pkg/kubelet/dockertools/docker.go @@ -306,8 +306,10 @@ func ConnectToDockerOrDie(dockerEndpoint string) DockerInterface { func milliCPUToShares(milliCPU int64) int64 { if milliCPU == 0 { - // zero milliCPU means unset. Use kernel default. - return 0 + // Docker converts zero milliCPU to unset, which maps to kernel default + // for unset: 1024. Return 2 here to really match kernel default for + // zero milliCPU. + return 2 } // Conceptually (milliCPU / milliCPUToCPU) * sharesPerCPU, but factored to improve rounding. shares := (milliCPU * sharesPerCPU) / milliCPUToCPU