github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 15:25:57 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #106653 from wpedrak/resilient-version.txt

Browse Source 
Make writing version.txt more resilient
This commit is contained in:
Kubernetes Prow Robot 2021-12-07 18:27:14 -08:00 committed by GitHub
commit 4c3bcf52db
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
cluster/images/etcd/migrate/data_dir.go
View File

@ -121,6 +121,10 @@ type VersionFile struct {
path string
}
func (v *VersionFile) nextPath() string {
return fmt.Sprintf("%s-next", v.path)
}
// Exists returns true if a version.txt file exists on the file system.
func (v *VersionFile) Exists() (bool, error) {
return exists(v.path)
@ -142,8 +146,14 @@ func (v *VersionFile) Read() (*EtcdVersionPair, error) {
// Write creates or overwrites the contents of the version.txt file with the given EtcdVersionPair.
func (v *VersionFile) Write(vp *EtcdVersionPair) error {
data := []byte(fmt.Sprintf("%s/%s", vp.version, vp.storageVersion))
return ioutil.WriteFile(v.path, data, 0666)
// We do write + rename instead of just write to protect from version.txt
// corruption under full disk condition.
// See https://github.com/kubernetes/kubernetes/issues/98989.
err := ioutil.WriteFile(v.nextPath(), []byte(vp.String()), 0666)
if err != nil {
return fmt.Errorf("failed to write new version file %s: %v", v.nextPath(), err)
}
return os.Rename(v.nextPath(), v.path)
}
func exists(path string) (bool, error) {