From d645056be1b89aa057844089110fe9f86270d956 Mon Sep 17 00:00:00 2001
From: Lorenzo Fontana <lo@linux.com>
Date: Thu, 12 Jul 2018 10:26:18 +0200
Subject: [PATCH] fieldpath: Add tests for missing cases

Signed-off-by: Lorenzo Fontana <lo@linux.com>
---
 pkg/fieldpath/fieldpath_test.go | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/pkg/fieldpath/fieldpath_test.go b/pkg/fieldpath/fieldpath_test.go
index aa87f02a8e1..66b2b325041 100644
--- a/pkg/fieldpath/fieldpath_test.go
+++ b/pkg/fieldpath/fieldpath_test.go
@@ -107,6 +107,28 @@ func TestExtractFieldPathAsString(t *testing.T) {
 			},
 			expectedValue: "1",
 		},
+		{
+			name:      "ok - uid",
+			fieldPath: "metadata.uid",
+			obj: &v1.Pod{
+				ObjectMeta: metav1.ObjectMeta{
+					UID: "b70b3269-858e-12a8-9cf2-1232a194038a",
+				},
+			},
+			expectedValue: "b70b3269-858e-12a8-9cf2-1232a194038a",
+		},
+		{
+			name:      "ok - label",
+			fieldPath: "metadata.labels['something']",
+			obj: &v1.Pod{
+				ObjectMeta: metav1.ObjectMeta{
+					Labels: map[string]string{
+						"something": "label value",
+					},
+				},
+			},
+			expectedValue: "label value",
+		},
 		{
 			name:      "invalid expression",
 			fieldPath: "metadata.whoops",
@@ -137,6 +159,12 @@ func TestExtractFieldPathAsString(t *testing.T) {
 			},
 			expectedMessageFragment: "invalid key subscript in metadata.labels",
 		},
+		{
+			name:      "invalid subscript",
+			fieldPath: "metadata.notexisting['something']",
+			obj:       &v1.Pod{},
+			expectedMessageFragment: "fieldPath \"metadata.notexisting['something']\" does not support subscript",
+		},
 	}
 
 	for _, tc := range cases {