From 4c6971007be59f8e11b801b75b27c5bdaadde1dc Mon Sep 17 00:00:00 2001 From: Feruzjon Muyassarov Date: Wed, 5 Mar 2025 12:20:37 +0200 Subject: [PATCH] Refine logging levels in Job, IPAM, and ReplicaSet controllers. Adjust logging levels in Job, IPAM, and ReplicaSet controllers from V(0) to V(2), V(4), V(4) respectively to reduce noise. These logs provide minimal value at the debug level (V(0)), so they have been adjusted for better log clarity Signed-off-by: Feruzjon Muyassarov --- pkg/controller/job/job_controller.go | 2 +- pkg/controller/nodeipam/ipam/range_allocator.go | 2 +- pkg/controller/replicaset/replica_set.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/controller/job/job_controller.go b/pkg/controller/job/job_controller.go index 2a811639d7f..b7da55b2031 100644 --- a/pkg/controller/job/job_controller.go +++ b/pkg/controller/job/job_controller.go @@ -595,7 +595,7 @@ func (jm *Controller) enqueueSyncJobInternal(logger klog.Logger, obj interface{} // all controllers there will still be some replica instability. One way to handle this is // by querying the store for all controllers that this rc overlaps, as well as all // controllers that overlap this rc, and sorting them. - logger.Info("enqueueing job", "key", key, "delay", delay) + logger.V(2).Info("enqueueing job", "key", key, "delay", delay) jm.queue.AddAfter(key, delay) } diff --git a/pkg/controller/nodeipam/ipam/range_allocator.go b/pkg/controller/nodeipam/ipam/range_allocator.go index 036030db516..50df3de49ce 100644 --- a/pkg/controller/nodeipam/ipam/range_allocator.go +++ b/pkg/controller/nodeipam/ipam/range_allocator.go @@ -244,7 +244,7 @@ func (r *rangeAllocator) processNextNodeWorkItem(ctx context.Context) bool { // Finally, if no error occurs we Forget this item so it does not // get queue again until another change happens. r.queue.Forget(obj) - logger.Info("Successfully synced", "key", key) + logger.V(4).Info("Successfully synced", "key", key) return nil }(klog.FromContext(ctx), obj) diff --git a/pkg/controller/replicaset/replica_set.go b/pkg/controller/replicaset/replica_set.go index b1e1beed452..ada439d360e 100644 --- a/pkg/controller/replicaset/replica_set.go +++ b/pkg/controller/replicaset/replica_set.go @@ -678,7 +678,7 @@ func (rsc *ReplicaSetController) syncReplicaSet(ctx context.Context, key string) logger := klog.FromContext(ctx) startTime := time.Now() defer func() { - logger.Info("Finished syncing", "kind", rsc.Kind, "key", key, "duration", time.Since(startTime)) + logger.V(4).Info("Finished syncing", "kind", rsc.Kind, "key", key, "duration", time.Since(startTime)) }() namespace, name, err := cache.SplitMetaNamespaceKey(key)