github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 21:17:23 +00:00
Code Issues Projects Releases Wiki Activity

Fix duplicate container query param on exec pod command

Browse Source 
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
This commit is contained in:
He Xiaoxi 2019-02-19 15:58:43 +08:00
parent 72be2f40b7
commit 4c8d0a3cd4
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/kubectl/cmd/exec/exec.go
View File

@ -311,8 +311,7 @@ func (p *ExecOptions) Run() error {
Resource("pods"). Resource("pods").
Name(pod.Name). Name(pod.Name).
Namespace(pod.Namespace). Namespace(pod.Namespace).
SubResource("exec"). SubResource("exec")
Param("container", containerName)
req.VersionedParams(&corev1.PodExecOptions{ req.VersionedParams(&corev1.PodExecOptions{
Container: containerName, Container: containerName,
Command: p.Command, Command: p.Command,

4
pkg/kubectl/cmd/exec/exec_test.go
View File

@ -244,6 +244,10 @@ func TestExec(t *testing.T) {
t.Errorf("%s: Did not get expected path for exec request", test.name) t.Errorf("%s: Did not get expected path for exec request", test.name)
return return
} }
if strings.Count(ex.url.RawQuery, "container=bar") != 1 {
t.Errorf("%s: Did not get expected container query param for exec request", test.name)
return
}
if ex.method != "POST" { if ex.method != "POST" {
t.Errorf("%s: Did not get method for exec request: %s", test.name, ex.method) t.Errorf("%s: Did not get method for exec request: %s", test.name, ex.method)
} }