github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 20:24:09 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #8644 from mbforbes/e2eLogBetter

Browse Source 
Better logging for e2e start (debug failing pods)
This commit is contained in:
Dawn Chen 2015-05-22 16:01:34 -07:00
commit 4cad3b568f
1 changed files with 32 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
test/e2e/util.go
View File

@ -118,18 +118,34 @@ func podReady(pod *api.Pod) bool {
return false return false
} }
// logPodStates logs all pod states for debugging. // logPodStates logs basic info of provided pods for debugging.
func logPodStates(c *client.Client, ns string) { func logPodStates(pods []api.Pod) {
podList, err := c.Pods(ns).List(labels.Everything(), fields.Everything()) // Find maximum widths for pod, node, and phase strings for column printing.
if err != nil { maxPodW, maxNodeW, maxPhaseW := len("POD"), len("NODE"), len("PHASE")
Logf("Error getting pods for logPodStates(...): %v", err) for _, pod := range pods {
return if len(pod.ObjectMeta.Name) > maxPodW {
maxPodW = len(pod.ObjectMeta.Name)
}
if len(pod.Spec.Host) > maxNodeW {
maxNodeW = len(pod.Spec.Host)
}
if len(pod.Status.Phase) > maxPhaseW {
maxPhaseW = len(pod.Status.Phase)
}
} }
Logf("Phase and conditions for all pods in namespace '%s':", ns) // Increase widths by one to separate by a single space.
for _, pod := range podList.Items { maxPodW++
Logf("- pod '%s' on '%s' has phase '%v' and conditions %v", maxNodeW++
pod.ObjectMeta.Name, pod.Spec.Host, pod.Status.Phase, pod.Status.Conditions) maxPhaseW++
// Log pod info. * does space padding, - makes them left-aligned.
Logf("%-[1]*[2]s %-[3]*[4]s %-[5]*[6]s %[7]s",
maxPodW, "POD", maxNodeW, "NODE", maxPhaseW, "PHASE", "CONDITIONS")
for _, pod := range pods {
Logf("%-[1]*[2]s %-[3]*[4]s %-[5]*[6]s %[7]s",
maxPodW, pod.ObjectMeta.Name, maxNodeW, pod.Spec.Host, maxPhaseW, pod.Status.Phase, pod.Status.Conditions)
} }
Logf("") // Final empty line helps for readability.
} }
// podRunningReady checks whether pod p's phase is running and it has a ready // podRunningReady checks whether pod p's phase is running and it has a ready
@ -169,19 +185,21 @@ func waitForPodsRunningReady(ns string, minPods int, timeout time.Duration) erro
Logf("Error getting pods in namespace '%s': %v", ns, err) Logf("Error getting pods in namespace '%s': %v", ns, err)
continue continue
} }
nOk := 0 nOk, badPods := 0, []api.Pod{}
for _, pod := range podList.Items { for _, pod := range podList.Items {
if res, err := podRunningReady(&pod); res && err == nil { if res, err := podRunningReady(&pod); res && err == nil {
nOk++ nOk++
} else {
badPods = append(badPods, pod)
} }
} }
Logf("%d / %d pods in namespace '%s' are running and ready (%v elapsed)", Logf("%d / %d pods in namespace '%s' are running and ready (%d seconds elapsed)",
nOk, len(podList.Items), ns, time.Since(start)) nOk, len(podList.Items), ns, int(time.Since(start).Seconds()))
if nOk == len(podList.Items) && nOk >= minPods { if nOk == len(podList.Items) && nOk >= minPods {
return nil return nil
} }
logPodStates(badPods)
} }
logPodStates(c, ns)
return fmt.Errorf("Not all pods in namespace '%s' running and ready within %v", ns, timeout) return fmt.Errorf("Not all pods in namespace '%s' running and ready within %v", ns, timeout)
} }