From 4cb48644874878ad7ae8418e9c95c1e0a95b820c Mon Sep 17 00:00:00 2001 From: danielqsj Date: Fri, 10 May 2019 11:46:30 +0800 Subject: [PATCH] replace test error checking with more readable way --- test/e2e/scheduling/limit_range.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/e2e/scheduling/limit_range.go b/test/e2e/scheduling/limit_range.go index b79034a8ea1..37b38d9ebff 100644 --- a/test/e2e/scheduling/limit_range.go +++ b/test/e2e/scheduling/limit_range.go @@ -130,12 +130,12 @@ var _ = SIGDescribe("LimitRange", func() { ginkgo.By("Failing to create a Pod with less than min resources") pod = f.NewTestPod(podName, getResourceList("10m", "50Mi", "50Gi"), v1.ResourceList{}) pod, err = f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(pod) - gomega.Expect(err).To(gomega.HaveOccurred()) + framework.ExpectError(err) ginkgo.By("Failing to create a Pod with more than max resources") pod = f.NewTestPod(podName, getResourceList("600m", "600Mi", "600Gi"), v1.ResourceList{}) pod, err = f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(pod) - gomega.Expect(err).To(gomega.HaveOccurred()) + framework.ExpectError(err) ginkgo.By("Updating a LimitRange") newMin := getResourceList("9m", "49Mi", "49Gi") @@ -158,7 +158,7 @@ var _ = SIGDescribe("LimitRange", func() { ginkgo.By("Failing to create a Pod with more than max resources") pod = f.NewTestPod(podName, getResourceList("600m", "600Mi", "600Gi"), v1.ResourceList{}) pod, err = f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(pod) - gomega.Expect(err).To(gomega.HaveOccurred()) + framework.ExpectError(err) ginkgo.By("Deleting a LimitRange") err = f.ClientSet.CoreV1().LimitRanges(f.Namespace.Name).Delete(limitRange.Name, metav1.NewDeleteOptions(30))