github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 06:27:05 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #84135 from RainbowMango/pr_remove_backoff

Browse Source 
Stop register to prom registry
This commit is contained in:
Kubernetes Prow Robot 2019-11-10 21:41:41 -08:00 committed by GitHub
commit 4cdb15f6cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
staging/src/k8s.io/component-base/metrics/legacyregistry/registry.go
View File

@ -49,18 +49,12 @@ func Handler() http.Handler {
// Register registers a collectable metric but uses the global registry // Register registers a collectable metric but uses the global registry
func Register(c metrics.Registerable) error { func Register(c metrics.Registerable) error {
err := defaultRegistry.Register(c) err := defaultRegistry.Register(c)
// sideload global prom registry as fallback
prometheus.Register(c)
return err return err
} }
// MustRegister registers registerable metrics but uses the global registry. // MustRegister registers registerable metrics but uses the global registry.
func MustRegister(cs ...metrics.Registerable) { func MustRegister(cs ...metrics.Registerable) {
defaultRegistry.MustRegister(cs...) defaultRegistry.MustRegister(cs...)
// sideload global prom registry as fallback
for _, c := range cs {
prometheus.Register(c)
}
} }
// RawMustRegister registers prometheus collectors but uses the global registry, this // RawMustRegister registers prometheus collectors but uses the global registry, this
@ -69,10 +63,6 @@ func MustRegister(cs ...metrics.Registerable) {
// Deprecated // Deprecated
func RawMustRegister(cs ...prometheus.Collector) { func RawMustRegister(cs ...prometheus.Collector) {
defaultRegistry.RawMustRegister(cs...) defaultRegistry.RawMustRegister(cs...)
// sideload global prom registry as fallback
for _, c := range cs {
prometheus.Register(c)
}
} }
// RawRegister registers a prometheus collector but uses the global registry, this // RawRegister registers a prometheus collector but uses the global registry, this
@ -81,8 +71,6 @@ func RawMustRegister(cs ...prometheus.Collector) {
// Deprecated // Deprecated
func RawRegister(c prometheus.Collector) error { func RawRegister(c prometheus.Collector) error {
err := defaultRegistry.RawRegister(c) err := defaultRegistry.RawRegister(c)
// sideload global prom registry as fallback
prometheus.Register(c)
return err return err
} }