From 4d3db1873f06106ec1f948e77aee646b9ed18aec Mon Sep 17 00:00:00 2001 From: Maciej Borsz Date: Thu, 13 Jun 2019 15:26:57 +0200 Subject: [PATCH] Don't leak ssh connections Without this fix, the underlying network connection is never closed. --- pkg/ssh/ssh.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/ssh/ssh.go b/pkg/ssh/ssh.go index 5b6cb4e1509..22e4aabed64 100644 --- a/pkg/ssh/ssh.go +++ b/pkg/ssh/ssh.go @@ -190,6 +190,7 @@ func runSSHCommand(dialer sshDialer, cmd, user, host string, signer ssh.Signer, if err != nil { return "", "", 0, fmt.Errorf("error getting SSH client to %s@%s: '%v'", user, host, err) } + defer client.Close() session, err := client.NewSession() if err != nil { return "", "", 0, fmt.Errorf("error creating session to %s@%s: '%v'", user, host, err)