From 4e1c3a5855f7cb3af9cb0925fa074e6b8de03856 Mon Sep 17 00:00:00 2001 From: Aldo Culquicondor Date: Wed, 30 Nov 2022 13:05:07 -0500 Subject: [PATCH] Dedup serialization of status Change-Id: Iaba63ea31e948933e162b3148cda2588af0fdaa3 --- pkg/scheduler/schedule_one.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pkg/scheduler/schedule_one.go b/pkg/scheduler/schedule_one.go index 4a45f5b4adb..c865c93815a 100644 --- a/pkg/scheduler/schedule_one.go +++ b/pkg/scheduler/schedule_one.go @@ -145,8 +145,9 @@ func (sched *Scheduler) schedulingCycle( if status.Code() == framework.Error { klog.ErrorS(nil, "Status after running PostFilter plugins for pod", "pod", klog.KObj(pod), "status", status) } else { - fitError.Diagnosis.PostFilterMsg = status.Message() - klog.V(5).InfoS("Status after running PostFilter plugins for pod", "pod", klog.KObj(pod), "status", status) + msg := status.Message() + fitError.Diagnosis.PostFilterMsg = msg + klog.V(5).InfoS("Status after running PostFilter plugins for pod", "pod", klog.KObj(pod), "status", msg) } if result != nil { nominatingInfo = result.NominatingInfo @@ -406,8 +407,9 @@ func (sched *Scheduler) findNodesThatFitPod(ctx context.Context, fwk framework.F return nil, diagnosis, s.AsError() } // Record the messages from PreFilter in Diagnosis.PreFilterMsg. - diagnosis.PreFilterMsg = s.Message() - klog.V(5).InfoS("Status after running PreFilter plugins for pod", "pod", klog.KObj(pod), "status", s) + msg := s.Message() + diagnosis.PreFilterMsg = msg + klog.V(5).InfoS("Status after running PreFilter plugins for pod", "pod", klog.KObj(pod), "status", msg) // Status satisfying IsUnschedulable() gets injected into diagnosis.UnschedulablePlugins. if s.FailedPlugin() != "" { diagnosis.UnschedulablePlugins.Insert(s.FailedPlugin())