From 4e21f535475e27fbb0b558a00de6d0d743ac3906 Mon Sep 17 00:00:00 2001 From: Tsubasa Nagasawa Date: Tue, 19 Nov 2024 23:56:17 +0900 Subject: [PATCH] Add test case for service with same named port for regular and sidecar containers --- .../src/k8s.io/endpointslice/utils_test.go | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/staging/src/k8s.io/endpointslice/utils_test.go b/staging/src/k8s.io/endpointslice/utils_test.go index 1e27e0c1f40..288c4e26fc3 100644 --- a/staging/src/k8s.io/endpointslice/utils_test.go +++ b/staging/src/k8s.io/endpointslice/utils_test.go @@ -631,6 +631,43 @@ func TestGetEndpointPorts(t *testing.T) { Protocol: &protoTCP, }}, }, + "service with same named port for regular and restartable init container": { + service: &v1.Service{ + Spec: v1.ServiceSpec{ + Ports: []v1.ServicePort{ + { + Name: "http", + Port: 80, + TargetPort: intstr.FromString("http"), + Protocol: protoTCP, + }}, + }, + }, + pod: &v1.Pod{ + Spec: v1.PodSpec{ + InitContainers: []v1.Container{{ + Ports: []v1.ContainerPort{{ + Name: "http", + ContainerPort: int32(8080), + Protocol: protoTCP, + }}, + RestartPolicy: &restartPolicyAlways, + }}, + Containers: []v1.Container{{ + Ports: []v1.ContainerPort{{ + Name: "http", + ContainerPort: int32(8090), + Protocol: protoTCP, + }}, + }}, + }, + }, + expectedPorts: []*discovery.EndpointPort{{ + Name: pointer.String("http"), + Port: pointer.Int32(8090), + Protocol: &protoTCP, + }}, + }, } for name, tc := range testCases {