github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-01-06 16:06:51 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #25273 from ncdc/exec-sigwinch

Browse Source 
Automatic merge from submit-queue

Support terminal resizing for exec/attach/run

```release-note
Add support for terminal resizing for exec, attach, and run. Note that for Docker, exec sessions
inherit the environment from the primary process, so if the container was created with tty=false,
that means the exec session's TERM variable will default to "dumb". Users can override this by
setting TERM=xterm (or whatever is appropriate) to get the correct "smart" terminal behavior.
```

Fixes #13585
This commit is contained in:
k8s-merge-robot
2016-07-14 07:26:49 -07:00
committed by GitHub
parent 6558b30f11 3b21a9901b
commit 50172148e4
41 changed files with 1246 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/kubelet/kubelet_test.go
View File

@@ -72,6 +72,7 @@ import (
"k8s.io/kubernetes/pkg/util/rand"
utilruntime "k8s.io/kubernetes/pkg/util/runtime"
"k8s.io/kubernetes/pkg/util/sets"
"k8s.io/kubernetes/pkg/util/term"
"k8s.io/kubernetes/pkg/util/wait"
"k8s.io/kubernetes/pkg/version"
"k8s.io/kubernetes/pkg/volume"
@@ -1036,7 +1037,7 @@ type fakeContainerCommandRunner struct {
Stream io.ReadWriteCloser
}
func (f *fakeContainerCommandRunner) ExecInContainer(id kubecontainer.ContainerID, cmd []string, in io.Reader, out, err io.WriteCloser, tty bool) error {
func (f *fakeContainerCommandRunner) ExecInContainer(id kubecontainer.ContainerID, cmd []string, in io.Reader, out, err io.WriteCloser, tty bool, resize <-chan term.Size) error {
f.Cmd = cmd
f.ID = id
f.Stdin = in
@@ -1983,6 +1984,7 @@ func TestExecInContainerNoSuchPod(t *testing.T) {
nil,
nil,
false,
nil,
)
if err == nil {
t.Fatal("unexpected non-error")
@@ -2027,6 +2029,7 @@ func TestExecInContainerNoSuchContainer(t *testing.T) {
nil,
nil,
false,
nil,
)
if err == nil {
t.Fatal("unexpected non-error")
@@ -2087,6 +2090,7 @@ func TestExecInContainer(t *testing.T) {
stdout,
stderr,
tty,
nil,
)
if err != nil {
t.Fatalf("unexpected error: %s", err)