From 3229a634a00c0346eee84384fb298eec46d43403 Mon Sep 17 00:00:00 2001 From: Paul Morie Date: Wed, 4 Feb 2015 14:21:33 -0500 Subject: [PATCH] Clarify commenting in endpoints_controller --- pkg/registry/service/rest_test.go | 2 +- pkg/service/endpoints_controller.go | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/registry/service/rest_test.go b/pkg/registry/service/rest_test.go index 82469b13f9f..1bb4776f10d 100644 --- a/pkg/registry/service/rest_test.go +++ b/pkg/registry/service/rest_test.go @@ -92,7 +92,7 @@ func TestServiceStorageValidatesCreate(t *testing.T) { Selector: map[string]string{"bar": "baz"}, }, }, - "empty selector": { + "empty port": { ObjectMeta: api.ObjectMeta{Name: "foo"}, Spec: api.ServiceSpec{ Selector: map[string]string{"bar": "baz"}, diff --git a/pkg/service/endpoints_controller.go b/pkg/service/endpoints_controller.go index d205914a3cc..3801972bb22 100644 --- a/pkg/service/endpoints_controller.go +++ b/pkg/service/endpoints_controller.go @@ -30,7 +30,7 @@ import ( "github.com/golang/glog" ) -// EndpointController manages service endpoints. +// EndpointController manages selector-based service endpoints. type EndpointController struct { client *client.Client } @@ -42,7 +42,7 @@ func NewEndpointController(client *client.Client) *EndpointController { } } -// SyncServiceEndpoints syncs service endpoints. +// SyncServiceEndpoints syncs endpoints for services with selectors. func (e *EndpointController) SyncServiceEndpoints() error { services, err := e.client.Services(api.NamespaceAll).List(labels.Everything()) if err != nil { @@ -52,7 +52,8 @@ func (e *EndpointController) SyncServiceEndpoints() error { var resultErr error for _, service := range services.Items { if service.Spec.Selector == nil { - // services without a selector receive no endpoints. The last endpoint will be used. + // services without a selector receive no endpoints from this controller; + // these services will receive the endpoints that are created out-of-band via the REST API. continue }