From 510140ee27f0be1eafaf2ea08f3e5e5c3d4561fa Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Mon, 9 Sep 2019 12:03:38 -0400 Subject: [PATCH] Avoid encoding from competing goroutines --- .../admissionwebhook/load_balance_test.go | 28 ++++++++++--------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/test/integration/apiserver/admissionwebhook/load_balance_test.go b/test/integration/apiserver/admissionwebhook/load_balance_test.go index da988a98c80..3281f6c9e26 100644 --- a/test/integration/apiserver/admissionwebhook/load_balance_test.go +++ b/test/integration/apiserver/admissionwebhook/load_balance_test.go @@ -154,17 +154,19 @@ func TestWebhookLoadBalance(t *testing.T) { t.Fatal(err) } - pod := &corev1.Pod{ - ObjectMeta: metav1.ObjectMeta{ - Namespace: ns, - GenerateName: "loadbalance-", - }, - Spec: corev1.PodSpec{ - Containers: []v1.Container{{ - Name: "fake-name", - Image: "fakeimage", - }}, - }, + pod := func() *corev1.Pod { + return &corev1.Pod{ + ObjectMeta: metav1.ObjectMeta{ + Namespace: ns, + GenerateName: "loadbalance-", + }, + Spec: corev1.PodSpec{ + Containers: []v1.Container{{ + Name: "fake-name", + Image: "fakeimage", + }}, + }, + } } // Submit 10 parallel requests @@ -173,7 +175,7 @@ func TestWebhookLoadBalance(t *testing.T) { wg.Add(1) go func() { defer wg.Done() - _, err := client.CoreV1().Pods(ns).Create(pod) + _, err := client.CoreV1().Pods(ns).Create(pod()) if err != nil { t.Error(err) } @@ -192,7 +194,7 @@ func TestWebhookLoadBalance(t *testing.T) { wg.Add(1) go func() { defer wg.Done() - _, err := client.CoreV1().Pods(ns).Create(pod) + _, err := client.CoreV1().Pods(ns).Create(pod()) if err != nil { t.Error(err) }