github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 22:17:14 +00:00
Code Issues Projects Releases Wiki Activity

make default values as const vars

Browse Source
This commit is contained in:
Di Xu 2017-07-20 16:13:17 +08:00
parent acc19cafa4
commit 50bfe02fea
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pkg/volume/rbd/rbd.go
View File

@ -56,10 +56,14 @@ var _ volume.DeletableVolumePlugin = &rbdPlugin{}
var _ volume.ProvisionableVolumePlugin = &rbdPlugin{}
const (
rbdPluginName = "kubernetes.io/rbd"
secretKeyName = "key" // key name used in secret
rbdImageFormat1 = "1"
rbdImageFormat2 = "2"
rbdPluginName = "kubernetes.io/rbd"
secretKeyName = "key" // key name used in secret
rbdImageFormat1 = "1"
rbdImageFormat2 = "2"
rbdDefaultAdminId = "admin"
rbdDefaultAdminSecretNamespace = "default"
rbdDefaultPool = "rbd"
rbdDefaultUserId = rbdDefaultAdminId
)
func (plugin *rbdPlugin) Init(host volume.VolumeHost) error {
@ -203,7 +207,7 @@ func (plugin *rbdPlugin) NewDeleter(spec *volume.Spec) (volume.Deleter, error) {
return nil, err
}
adminSecretName := ""
adminSecretNamespace := "default"
adminSecretNamespace := rbdDefaultAdminSecretNamespace
admin := ""
for k, v := range class.Parameters {
@ -271,7 +275,7 @@ func (r *rbdVolumeProvisioner) Provision() (*v1.PersistentVolume, error) {
}
var err error
adminSecretName := ""
adminSecretNamespace := "default"
adminSecretNamespace := rbdDefaultAdminSecretNamespace
secretName := ""
secret := ""
imageFormat := rbdImageFormat1
@ -330,10 +334,10 @@ func (r *rbdVolumeProvisioner) Provision() (*v1.PersistentVolume, error) {
return nil, fmt.Errorf("missing user secret name")
}
if r.adminId == "" {
r.adminId = "admin"
r.adminId = rbdDefaultAdminId
}
if r.Pool == "" {
r.Pool = "rbd"
r.Pool = rbdDefaultPool
}
if r.Id == "" {
r.Id = r.adminId