github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #111189 from Octopusjust/k8s-pr4

Browse Source 
Add testcases for cmd/kubeadm/app/util/net.go and version.go
This commit is contained in:
Kubernetes Prow Robot 2022-07-18 02:49:27 -07:00 committed by GitHub
commit 5108b0a3a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/kubeadm/app/util/net_test.go
View File

@ -44,6 +44,12 @@ func TestGetHostname(t *testing.T) {
result: "overridden", result: "overridden",
expectedErr: nil, expectedErr: nil,
}, },
{
desc: "hostname contains spaces",
hostname: " OVERRIDDEN ",
result: "overridden",
expectedErr: nil,
},
{ {
desc: "hostname contains only spaces", desc: "hostname contains only spaces",
hostname: " ", hostname: " ",

5
cmd/kubeadm/app/util/version_test.go
View File

@ -381,6 +381,11 @@ func TestKubeadmVersion(t *testing.T) {
input: "v1.9", input: "v1.9",
parsingError: true, parsingError: true,
}, },
{
name: "invalid version with label and stray dot",
input: "v1.8.0-alpha.2.",
parsingError: true,
},
{ {
name: "invalid version with label and metadata", name: "invalid version with label and metadata",
input: "v1.8.0-alpha.2.1231+afabd012389d53a", input: "v1.8.0-alpha.2.1231+afabd012389d53a",