From 51b75460aa356a6b07cd5d727cc3ad6c00a13f20 Mon Sep 17 00:00:00 2001
From: jennybuckley <jennybuckley@google.com>
Date: Wed, 6 Mar 2019 15:57:18 -0800
Subject: [PATCH] handle validation errors correctly

---
 staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go b/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go
index d307cd18551..149659df9ce 100644
--- a/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go
+++ b/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go
@@ -330,7 +330,7 @@ func cleanVerb(verb string, request *http.Request) string {
 }
 
 func cleanDryRun(dryRun []string) string {
-	if err := validation.ValidateDryRun(nil, dryRun); err != nil {
+	if errs := validation.ValidateDryRun(nil, dryRun); len(errs) > 0 {
 		return "invalid"
 	}