From 7bd9ddef607467a1190e6b134a3ff25a483fd24f Mon Sep 17 00:00:00 2001 From: xilabao Date: Thu, 20 Apr 2017 08:54:39 +0800 Subject: [PATCH] remove resourcename validation in create role --- pkg/kubectl/cmd/create_role.go | 5 ----- pkg/kubectl/cmd/create_role_test.go | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/pkg/kubectl/cmd/create_role.go b/pkg/kubectl/cmd/create_role.go index 5074fec2cd0..151122c98fc 100644 --- a/pkg/kubectl/cmd/create_role.go +++ b/pkg/kubectl/cmd/create_role.go @@ -207,11 +207,6 @@ func (c *CreateRoleOptions) Validate() error { } } - // validate resource names, can not apply resource names to multiple resources. - if len(c.ResourceNames) > 0 && len(c.Resources) > 1 { - return fmt.Errorf("resource name(s) can not be applied to multiple resources") - } - return nil } diff --git a/pkg/kubectl/cmd/create_role_test.go b/pkg/kubectl/cmd/create_role_test.go index c71ccc52225..c57e6d232ea 100644 --- a/pkg/kubectl/cmd/create_role_test.go +++ b/pkg/kubectl/cmd/create_role_test.go @@ -256,7 +256,7 @@ func TestValidate(t *testing.T) { }, ResourceNames: []string{"foo"}, }, - expectErr: true, + expectErr: false, }, "test-valid-case": { roleOptions: &CreateRoleOptions{