mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-22 19:31:44 +00:00
Merge pull request #82105 from logicalhan/admission-test
Explicitly handle returned error values in admission metrics_test
This commit is contained in:
commit
5219ad7be2
@ -37,8 +37,12 @@ var (
|
||||
func TestObserveAdmissionStep(t *testing.T) {
|
||||
Metrics.reset()
|
||||
handler := WithStepMetrics(&mutatingAndValidatingFakeHandler{admission.NewHandler(admission.Create), true, true})
|
||||
handler.(admission.MutationInterface).Admit(context.TODO(), attr, nil)
|
||||
handler.(admission.ValidationInterface).Validate(context.TODO(), attr, nil)
|
||||
if err := handler.(admission.MutationInterface).Admit(context.TODO(), attr, nil); err != nil {
|
||||
t.Errorf("Unexpected error in admit: %v", err)
|
||||
}
|
||||
if err := handler.(admission.ValidationInterface).Validate(context.TODO(), attr, nil); err != nil {
|
||||
t.Errorf("Unexpected error in validate: %v", err)
|
||||
}
|
||||
wantLabels := map[string]string{
|
||||
"operation": string(admission.Create),
|
||||
"type": "admit",
|
||||
@ -55,8 +59,12 @@ func TestObserveAdmissionStep(t *testing.T) {
|
||||
func TestObserveAdmissionController(t *testing.T) {
|
||||
Metrics.reset()
|
||||
handler := WithControllerMetrics(&mutatingAndValidatingFakeHandler{admission.NewHandler(admission.Create), true, true}, "a")
|
||||
handler.(admission.MutationInterface).Admit(context.TODO(), attr, nil)
|
||||
handler.(admission.ValidationInterface).Validate(context.TODO(), attr, nil)
|
||||
if err := handler.(admission.MutationInterface).Admit(context.TODO(), attr, nil); err != nil {
|
||||
t.Errorf("Unexpected error in admit: %v", err)
|
||||
}
|
||||
if err := handler.(admission.ValidationInterface).Validate(context.TODO(), attr, nil); err != nil {
|
||||
t.Errorf("Unexpected error in validate: %v", err)
|
||||
}
|
||||
wantLabels := map[string]string{
|
||||
"name": "a",
|
||||
"operation": string(admission.Create),
|
||||
|
Loading…
Reference in New Issue
Block a user